Attachment 142147 Details for Bug 31869 – Bug 31869: Unable to save thesaurus value to frameworks subfields

[patch] Bug 31869: Unable to save thesaurus value to frameworks subfields

Bug-31869-Unable-to-save-thesaurus-value-to-framew.patch (text/plain), 2.14 KB, created by Nick Clemens (kidclamp) on 2022-10-19 11:23:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-10-19 11:23:39 UTC

Size: 2.14 KB

patch

obsolete

>From 1b7cde4a80c8269383dfe3fe0e79807be6a9d390 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 19 Oct 2022 11:17:37 +0000
>Subject: [PATCH] Bug 31869: Unable to save thesaurus value to frameworks
> subfields
>
>This patch correct a typo authtypecodes for authtypecode
>
>To test:
>1. Edit e.g. default frameworks subfield 100$a
>2. Add or change fields thesaurus value
>3. Save your changes
>   => note that on subfield listing there is no mention that 100$a is linked to any thesaurus
>   => if you edit 100$a thesaurus input is empty
>4. Apply patch
>5. Edit subfield 100$a and set a thesaurus value
>6. Confirm it saves and displays correctly
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/Auth/Client/OAuth.pm         | 1 +
> admin/marc_subfields_structure.pl | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Auth/Client/OAuth.pm b/Koha/Auth/Client/OAuth.pm
>index 728fa4e3ec..e5cb453641 100644
>--- a/Koha/Auth/Client/OAuth.pm
>+++ b/Koha/Auth/Client/OAuth.pm
>@@ -65,6 +65,7 @@ sub _get_data_and_patron {
>         my ( $header_part, $claims_part, $footer_part ) = split( /\./, $data->{id_token} );
> 
>         my $claim = decode_json( decode_base64url($claims_part) );
>+        warn Data::Dumper::Dumper( $claim );
>         foreach my $key ( keys %$mapping ) {
>             my $pkey = $mapping->{$key};
>             $mapped_data->{$key} = $claim->{$pkey}
>diff --git a/admin/marc_subfields_structure.pl b/admin/marc_subfields_structure.pl
>index a2755df645..79232aeceb 100755
>--- a/admin/marc_subfields_structure.pl
>+++ b/admin/marc_subfields_structure.pl
>@@ -229,7 +229,7 @@ elsif ( $op eq 'add_validate' ) {
>         my $tab              = $input->param("tab_$id");
>         my $seealso          = $input->param("seealso_$id");
>         my $authorised_value = $input->param("authorised_value_$id");
>-        my $authtypecode     = $input->param("authtypecodes_$id");
>+        my $authtypecode     = $input->param("authtypecode_$id");
>         my $value_builder    = $input->param("value_builder_$id");
>         my $hidden = $input->param("hidden_$id");
>         my $isurl  = $input->param("isurl_$id") ? 1 : 0;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31869: 142147 | 142244 | 142477