Attachment 142249 Details for Bug 29012 – Bug 29012: Fix undef warnings around unseen_renewals_allowed in smart-rules.pl

[patch] Bug 29012: Fix undef warnings around unseen_renewals_allowed in smart-rules.pl

Bug-29012-Fix-undef-warnings-around-unseenrenewals.patch (text/plain), 1.54 KB, created by Tomás Cohen Arazi (tcohen) on 2022-10-20 14:20:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-10-20 14:20:27 UTC

Size: 1.54 KB

patch

obsolete

>From 98f50491bd35e9dbda522cf2b7028e15f7a64d13 Mon Sep 17 00:00:00 2001
>From: Slava Shishkin <slavashishkin@gmail.com>
>Date: Tue, 11 Oct 2022 18:18:23 +0300
>Subject: [PATCH] Bug 29012: Fix undef warnings around unseen_renewals_allowed
> in smart-rules.pl
>
>Trivial fix.
>
>To reproduce:
>1. Create or edit a rule on /cgi-bin/koha/admin/smart-rules.pl - i.e. submit the form (make POST request)
>2. Notice the mentioned above warning in plack-intranet-error.log
>3. Apply the patch.
>4. Repeat step 1.
>5. That warning in log file should be no more.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> admin/smart-rules.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl
>index 3583f598848..7c3b5b86aeb 100755
>--- a/admin/smart-rules.pl
>+++ b/admin/smart-rules.pl
>@@ -263,7 +263,7 @@ elsif ($op eq 'add') {
>     my $maxissueqty = strip_non_numeric( scalar $input->param('maxissueqty') );
>     my $maxonsiteissueqty = strip_non_numeric( scalar $input->param('maxonsiteissueqty') );
>     my $renewalsallowed  = $input->param('renewalsallowed');
>-    my $unseen_renewals_allowed  = strip_non_numeric( scalar $input->param('unseen_renewals_allowed') ) // q{};
>+    my $unseen_renewals_allowed  = defined $input->param('unseen_renewals_allowed') ? strip_non_numeric( scalar $input->param('unseen_renewals_allowed') ) : q{};
>     my $renewalperiod    = $input->param('renewalperiod');
>     my $norenewalbefore  = $input->param('norenewalbefore');
>     $norenewalbefore = q{} if $norenewalbefore =~ /^\s*$/;
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 29012: 128205 | 128206 | 131043 | 131053 | 131054 | 135194 | 135998 | 138140 | 138309 | 138310 | 141869 | 141876 | 141877 | 141878 | 141879 | 141951 | 141952 | 142248 | 142249