Bugzilla – Attachment 142275 Details for
Bug 31889
Insert 952 tags in correct order when embedding items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31889: Replace append_fields in _embed_items
Bug-31889-Replace-appendfields-in-embeditems.patch (text/plain), 974 bytes, created by
David Nind
on 2022-10-20 18:19:43 UTC
(
hide
)
Description:
Bug 31889: Replace append_fields in _embed_items
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-10-20 18:19:43 UTC
Size:
974 bytes
patch
obsolete
>From 31056b884a257f21be92da7454522f1451a476d6 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 20 Oct 2022 14:27:25 +0000 >Subject: [PATCH] Bug 31889: Replace append_fields in _embed_items > >Test plan: >Run t/db_dependent/Koha/Biblio/Metadata.t again. Should pass. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/Biblio/Metadata.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Biblio/Metadata.pm b/Koha/Biblio/Metadata.pm >index 78361ab261..09291b2f8a 100644 >--- a/Koha/Biblio/Metadata.pm >+++ b/Koha/Biblio/Metadata.pm >@@ -172,7 +172,7 @@ sub _embed_items { > my $item_marc = C4::Items::GetMarcItem( $biblionumber, $itemnumber ); > push @item_fields, $item_marc->field($itemtag); > } >- $record->append_fields(@item_fields); >+ $record->insert_fields_ordered(@item_fields); > > } > else { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31889
:
142254
|
142255
|
142256
|
142273
|
142274
|
142275
|
143035
|
143036
|
143037
|
143348
|
143350