Bugzilla – Attachment 142358 Details for
Bug 30588
Add the option to require 2FA setup on first staff login
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30588: (QA follow-up) Clear waiting-for-2FA-setup in session
Bug-30588-QA-follow-up-Clear-waiting-for-2FA-setup.patch (text/plain), 1.35 KB, created by
Nick Clemens (kidclamp)
on 2022-10-21 12:28:59 UTC
(
hide
)
Description:
Bug 30588: (QA follow-up) Clear waiting-for-2FA-setup in session
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-10-21 12:28:59 UTC
Size:
1.35 KB
patch
obsolete
>From b18ad5fa6a2fca24268d7878ece0a9dd6ce54ea2 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 12 Sep 2022 09:02:21 +0000 >Subject: [PATCH] Bug 30588: (QA follow-up) Clear waiting-for-2FA-setup in > session > >If we do not clear this session, the first login directly after setup >does not really enhances user experience ;) > >Test plan: >Make sure 2FA is enforced. >Test the above. Disable your 2FA, logout and login. >Verify that you can access pages with this patch now. Without this >patch you could not. >Run these tests to provide more confidence: >t/db_dependent/Auth.t >t/db_dependent/api/v1/two_factor_auth.t >t/db_dependent/Koha/Auth/TwoFactorAuth.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Auth.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 843079f13f..2aa2a20774 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -875,6 +875,7 @@ sub checkauth { > # The token is correct, the user is fully logged in! > $auth_state = 'completed'; > $session->param( 'waiting-for-2FA', 0 ); >+ $session->param( 'waiting-for-2FA-setup', 0 ); > > # This is an ugly trick to pass the test > # $query->param('koha_login_context') && ( $q_userid ne $userid ) >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30588
:
138160
|
138161
|
138162
|
138163
|
138164
|
138165
|
138166
|
138191
|
138193
|
138953
|
138954
|
138955
|
138956
|
138957
|
138958
|
138959
|
138960
|
138961
|
138962
|
140365
|
140366
|
140367
|
140368
|
140369
|
140416
|
140417
|
140418
|
140419
|
140420
|
140421
|
140422
|
140423
|
140424
|
140425
|
140426
|
140427
|
140428
|
140429
|
140430
|
141978
|
141979
|
141980
|
141981
|
141982
|
141983
|
141984
|
141985
|
141986
|
141987
|
141988
|
141989
|
141990
|
141991
|
141992
|
142344
|
142345
|
142346
|
142347
|
142348
|
142349
|
142350
|
142351
|
142352
|
142353
|
142354
|
142355
|
142356
|
142357
| 142358