Attachment 142423 Details for Bug 24860 – Bug 24860: (QA follow-up) Terminology and translation fixes

[patch] Bug 24860: (QA follow-up) Terminology and translation fixes

Bug-24860-QA-follow-up-Terminology-and-translation.patch (text/plain), 3.60 KB, created by Kyle M Hall (khall) on 2022-10-21 16:04:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-10-21 16:04:49 UTC

Size: 3.60 KB

patch

obsolete

>From f90711baca7464b93b8a2484e5f3eca4d15c8568 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 2 Oct 2022 21:15:42 +0000
>Subject: [PATCH] Bug 24860: (QA follow-up) Terminology and translation fixes
>
>* Fixes a single to a double underscore for translation in holds.js
>* Fixes item_group to item group in API description
>* Fixes volume hold to item group hold in syspref db descrpitions
>---
> api/v1/swagger/definitions/hold.yaml             | 2 +-
> installer/data/mysql/atomicupdate/bug_24860.perl | 2 +-
> installer/data/mysql/mandatory/sysprefs.sql      | 2 +-
> koha-tmpl/intranet-tmpl/prog/js/holds.js         | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/api/v1/swagger/definitions/hold.yaml b/api/v1/swagger/definitions/hold.yaml
>index 2c5ac09f8d..a7d0d39330 100644
>--- a/api/v1/swagger/definitions/hold.yaml
>+++ b/api/v1/swagger/definitions/hold.yaml
>@@ -20,7 +20,7 @@ properties:
>     type:
>       - string
>       - "null"
>-    description: Internal item_group identifier
>+    description: Internal item group identifier
>   pickup_library_id:
>     type:
>       - string
>diff --git a/installer/data/mysql/atomicupdate/bug_24860.perl b/installer/data/mysql/atomicupdate/bug_24860.perl
>index 010f74c157..861dc759d8 100644
>--- a/installer/data/mysql/atomicupdate/bug_24860.perl
>+++ b/installer/data/mysql/atomicupdate/bug_24860.perl
>@@ -18,7 +18,7 @@ if ( CheckVersion( $DBversion ) ) {
> 
>     $dbh->do(q{
>         INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
>-        ('EnableItemGroupHolds','0','','Enable volume level holds feature','YesNo')
>+        ('EnableItemGroupHolds','0','','Enable item group holds feature','YesNo')
>     });
> 
>     SetVersion( $DBversion );
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
>index f015feba38..d1ecaa24d1 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -216,7 +216,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('EnablePointOfSale','0',NULL,'Enable the point of sale feature to allow anonymous transactions with the accounting system. (Requires UseCashRegisters)','YesNo'),
> ('EnableSearchHistory','0','','Enable or disable search history','YesNo'),
> ('EnableItemGroups','0','','Enable the item groups feature','YesNo'),
>-('EnableItemGroupHolds','0','','Enable volume level holds feature','YesNo'),
>+('EnableItemGroupHolds','0','','Enable item groups holds feature','YesNo'),
> ('EnhancedMessagingPreferences','1','','If ON, allows patrons to select to receive additional messages about items due or nearly due.','YesNo'),
> ('EnhancedMessagingPreferencesOPAC', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo'),
> ('expandedSearchOption','0',NULL,'If ON, set advanced search to be expanded by default','YesNo'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js
>index 3465847de2..0b223bf302 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js
>@@ -279,7 +279,7 @@ $(document).ready(function() {
>                             }
> 
>                             if ( oObj.item_group_id ) {
>-                                data += _("Next available item group <strong>%s</strong> item").format( oObj.item_group_description );
>+                                data += __("Next available item group <strong>%s</strong> item").format( oObj.item_group_description );
>                             }
> 
>                             if ( oObj.barcode ) {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 24860: 100644 | 100645 | 100646 | 100647 | 100648 | 100649 | 100650 | 100651 | 101744 | 101745 | 101746 | 101747 | 101748 | 101749 | 101750 | 101751 | 101827 | 101828 | 101829 | 101830 | 101831 | 101832 | 101833 | 101834 | 101835 | 102230 | 102231 | 102232 | 102233 | 102234 | 102235 | 102236 | 102237 | 102238 | 102239 | 102240 | 102241 | 102242 | 102243 | 102244 | 102245 | 102246 | 102247 | 106589 | 106590 | 106591 | 106592 | 106593 | 106594 | 106595 | 106596 | 106597 | 106682 | 106683 | 106684 | 106685 | 106686 | 106687 | 106688 | 106689 | 106690 | 106742 | 106743 | 106744 | 106745 | 106746 | 106747 | 106748 | 106749 | 106750 | 108458 | 108459 | 108460 | 108461 | 108462 | 108463 | 108464 | 108465 | 108466 | 109097 | 109098 | 109099 | 109100 | 109101 | 109102 | 109103 | 109104 | 109105 | 109171 | 109172 | 109173 | 109174 | 109175 | 109176 | 109177 | 109178 | 109179 | 113616 | 113617 | 113618 | 113619 | 113620 | 113621 | 113622 | 113623 | 113624 | 135922 | 135923 | 135924 | 135925 | 135926 | 135927 | 135928 | 135929 | 135930 | 138221 | 138222 | 138224 | 138225 | 138226 | 138227 | 138228 | 138229 | 138230 | 141214 | 141215 | 141735 | 141736 | 141737 | 141738 | 141739 | 141740 | 141741 | 141742 | 141743 | 141744 | 141745 | 141746 | 141747 | 141748 | 141749 | 141750 | 142413 | 142414 | 142415 | 142416 | 142417 | 142418 | 142419 | 142420 | 142421 | 142422 | 142423 | 142424 | 142425 | 142426 | 142427 | 142428 | 142429 | 142430 | 142827 | 142955 | 142956 | 142957 | 142958 | 142959 | 142960 | 142961 | 142962 | 142963 | 142964 | 142965 | 142966 | 142967 | 142968 | 142969 | 142970 | 142971 | 142972 | 142973 | 142974 | 142975 | 142992 | 142993 | 142994 | 142995 | 142996 | 142997 | 142998 | 142999 | 143000 | 143001 | 143002 | 143003 | 143004 | 143005 | 143006 | 143007 | 143008 | 143009 | 143010 | 143011