Attachment 142431 Details for Bug 12446 – Bug 12446: Remove can_be_guarentee is_boolean to put it back in another patch

[patch] Bug 12446: Remove can_be_guarentee is_boolean to put it back in another patch

Bug-12446-Remove-canbeguarentee-isboolean-to-put-i.patch (text/plain), 3.35 KB, created by geraud.frappier on 2022-10-21 17:19:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: geraud.frappier

Created: 2022-10-21 17:19:20 UTC

Size: 3.35 KB

patch

obsolete

>From da1000d6ce4849fa845c81706c58c10f9addf385 Mon Sep 17 00:00:00 2001
>From: Shi Yao Wang <shi-yao.wang@inlibro.com>
>Date: Wed, 1 Jun 2022 08:59:20 -0400
>Subject: [PATCH] Bug 12446: Remove can_be_guarentee is_boolean to put it back
> in another patch
>
>This patch resolve merge conflit and add the instantiation of the variable "my $categories" that was missing in memberentry.pl.
>---
> Koha/Schema/Result/Category.pm |  4 ----
> members/memberentry.pl         | 29 +++--------------------------
> 2 files changed, 3 insertions(+), 30 deletions(-)
>
>diff --git a/Koha/Schema/Result/Category.pm b/Koha/Schema/Result/Category.pm
>index 1058bc2ac6..a83ebd68a2 100644
>--- a/Koha/Schema/Result/Category.pm
>+++ b/Koha/Schema/Result/Category.pm
>@@ -374,10 +374,6 @@ __PACKAGE__->has_many(
> # Created by DBIx::Class::Schema::Loader v0.07049 @ 2022-06-23 16:29:27
> # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:SKWF2QpqQtXoujwurKFQhA
> 
>-__PACKAGE__->add_columns(
>-    '+canbeguarantee' => { is_boolean => 1 }
>-);
>-
> sub koha_object_class {
>     'Koha::Patron::Category';
> }
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index ed690226e2..a11521bd0b 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -651,35 +651,14 @@ if(!defined($data{'sex'})){
> 
> my @typeloop;
> my $no_categories = 1;
>-my $no_add;
>+
> foreach my $category_type (qw(C A S P I X)) {
>     my $categories_limits = { category_type => $category_type };
>     $categories_limits->{canbeguarantee} = 1 if ($guarantor_id);
>     my $patron_categories = Koha::Patron::Categories->search_with_library_limits( $categories_limits, {order_by => ['categorycode']} );
>     $no_categories = 0 if $patron_categories->count > 0;
>-
>-    my @categoryloop;
>-    while ( my $patron_category = $patron_categories->next ) {
>-        push @categoryloop,
>-          { 'categorycode' => $patron_category->categorycode,
>-            'categoryname' => $patron_category->description,
>-            'effective_min_password_length' => $patron_category->effective_min_password_length,
>-            'effective_require_strong_password' => $patron_category->effective_require_strong_password,
>-            'categorycodeselected' =>
>-              ( defined($categorycode) && $patron_category->categorycode eq $categorycode ),
>-          };
>-    }
>-    my %typehash;
>-    $typehash{'typename'} = $category_type;
>-    my $typedescription = "typename_" . $typehash{'typename'};
>-    $typehash{'categoryloop'} = \@categoryloop;
>-    push @typeloop,
>-      { 'typename'       => $category_type,
>-        $typedescription => 1,
>-        'categoryloop'   => \@categoryloop
>-      };
> }
>-
>+my $categories;
> $template->param(
>     patron_categories => $categories,
>     no_categories => $no_categories,
>@@ -779,9 +758,7 @@ $template->param(  step  => $step   ) if $step;	# associate with step to know wh
> 
> $template->param(
>   BorrowerMandatoryField => C4::Context->preference("BorrowerMandatoryField"),#field to test with javascript
>-  category_type => $category_type,#to know the category type of the borrower
>-  "$category_type"  => 1,# associate with step to know where u are
>-  destination   => $destination,#to know where u come from and where u must go in redirect
>+  destination   => $destination,#to know where u come from and wheree u must go in redirect
>   check_member    => $check_member,#to know if the borrower already exist(=>1) or not (=>0) 
>   "op$op"   => 1);
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 12446: 29278 | 36176 | 39744 | 42469 | 42470 | 42535 | 46277 | 46278 | 46327 | 46328 | 46345 | 46486 | 49793 | 50953 | 53534 | 53535 | 53536 | 53913 | 60929 | 60930 | 60934 | 63148 | 63149 | 63214 | 64793 | 64794 | 64828 | 72295 | 72883 | 77766 | 77767 | 77768 | 79343 | 79344 | 79345 | 79347 | 79348 | 85069 | 88364 | 88365 | 88366 | 88367 | 90389 | 90390 | 90391 | 90392 | 90470 | 90471 | 90472 | 90473 | 93388 | 93389 | 93390 | 93391 | 93392 | 93393 | 93394 | 95411 | 95853 | 95854 | 95855 | 95856 | 95857 | 95858 | 95859 | 95860 | 106753 | 106754 | 106755 | 106756 | 106757 | 107611 | 111052 | 111053 | 111317 | 111318 | 112102 | 112160 | 112161 | 112162 | 112163 | 113583 | 121925 | 121926 | 121927 | 121928 | 121929 | 122084 | 122085 | 122086 | 122087 | 122088 | 122089 | 122090 | 122091 | 122184 | 122185 | 122186 | 122187 | 130398 | 130399 | 130400 | 130401 | 130402 | 131965 | 131966 | 131967 | 131968 | 131969 | 133691 | 133952 | 133953 | 133954 | 133955 | 133956 | 133957 | 134930 | 134931 | 134932 | 134933 | 134934 | 134935 | 134936 | 135506 | 135507 | 135508 | 135509 | 135510 | 135511 | 135512 | 135519 | 135520 | 135521 | 135522 | 135523 | 135544 | 135545 | 142401 | 142408 | 142431 | 142432 | 142433 | 142434 | 142435 | 142436 | 142437 | 142438 | 142439