Attachment 142434 Details for Bug 12446 – Bug 12446: Limit available categories when using "Add guarantee" button

[patch] Bug 12446: Limit available categories when using "Add guarantee" button

Bug-12446-Limit-available-categories-when-using-Ad.patch (text/plain), 2.08 KB, created by geraud.frappier on 2022-10-21 18:03:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: geraud.frappier

Created: 2022-10-21 18:03:48 UTC

Size: 2.08 KB

patch

obsolete

>From ee67d86081b854d3a8fc91b7ab710f63fe3a648a Mon Sep 17 00:00:00 2001
>From: Maryse Simard <maryse.simard@inlibro.com>
>Date: Tue, 20 Oct 2020 20:39:51 -0400
>Subject: [PATCH] Bug 12446: Limit available categories when using "Add
> guarantee" button
>
>Test plan:
>1) Have some patron categories that can and cannot be guarantee
>2) Visit a patron's account and click the "Add guarantee" button
>3) In the "category" dropdown, note that all categories are available
>4) Apply this patch
>5) Repeat step 2 and 3; the dropdown now only contains the categories
>for which "can be guarantee" is set to "Yes".
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> members/memberentry.pl | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index dcb6d9fd6d..567458642f 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -649,18 +649,14 @@ if(!defined($data{'sex'})){
> 
> ##Now all the data to modify a member.
> 
>-my $patron_categories = Koha::Patron::Categories->search_with_library_limits(
>-    {
>-        category_type => [qw(C A S P I X)],
>-        ( $guarantor_id ? ( can_be_guarantee => 1 ) : () )
>-    },
>-    { order_by => ['categorycode'] }
>-);
>-my $no_categories = ! $patron_categories->count;
>-my $categories = {};
>-foreach my $patron_category ($patron_categories->as_list ) {
>-    push @{ $categories->{ $patron_category->category_type } }, $patron_category;
>-}
>+my @typeloop;
>+my $no_categories = 1;
>+my $no_add;
>+foreach my $category_type (qw(C A S P I X)) {
>+    my $categories_limits = { category_type => $category_type };
>+    $categories_limits->{canbeguarantee} = 1 if ($guarantor_id);
>+    my $patron_categories = Koha::Patron::Categories->search_with_library_limits( $categories_limits, {order_by => ['categorycode']} );
>+    $no_categories = 0 if $patron_categories->count > 0;
> 
> $template->param(
>     patron_categories => $categories,
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 12446: 29278 | 36176 | 39744 | 42469 | 42470 | 42535 | 46277 | 46278 | 46327 | 46328 | 46345 | 46486 | 49793 | 50953 | 53534 | 53535 | 53536 | 53913 | 60929 | 60930 | 60934 | 63148 | 63149 | 63214 | 64793 | 64794 | 64828 | 72295 | 72883 | 77766 | 77767 | 77768 | 79343 | 79344 | 79345 | 79347 | 79348 | 85069 | 88364 | 88365 | 88366 | 88367 | 90389 | 90390 | 90391 | 90392 | 90470 | 90471 | 90472 | 90473 | 93388 | 93389 | 93390 | 93391 | 93392 | 93393 | 93394 | 95411 | 95853 | 95854 | 95855 | 95856 | 95857 | 95858 | 95859 | 95860 | 106753 | 106754 | 106755 | 106756 | 106757 | 107611 | 111052 | 111053 | 111317 | 111318 | 112102 | 112160 | 112161 | 112162 | 112163 | 113583 | 121925 | 121926 | 121927 | 121928 | 121929 | 122084 | 122085 | 122086 | 122087 | 122088 | 122089 | 122090 | 122091 | 122184 | 122185 | 122186 | 122187 | 130398 | 130399 | 130400 | 130401 | 130402 | 131965 | 131966 | 131967 | 131968 | 131969 | 133691 | 133952 | 133953 | 133954 | 133955 | 133956 | 133957 | 134930 | 134931 | 134932 | 134933 | 134934 | 134935 | 134936 | 135506 | 135507 | 135508 | 135509 | 135510 | 135511 | 135512 | 135519 | 135520 | 135521 | 135522 | 135523 | 135544 | 135545 | 142401 | 142408 | 142431 | 142432 | 142433 | 142434 | 142435 | 142436 | 142437 | 142438 | 142439