Bugzilla – Attachment 142486 Details for
Bug 23012
Possibility to mark processing fee by default refund when item is found
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23012: (QA follow-up) No need to create and delete rules for branch
Bug-23012-QA-follow-up-No-need-to-create-and-delet.patch (text/plain), 2.66 KB, created by
Nick Clemens (kidclamp)
on 2022-10-24 11:23:53 UTC
(
hide
)
Description:
Bug 23012: (QA follow-up) No need to create and delete rules for branch
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-10-24 11:23:53 UTC
Size:
2.66 KB
patch
obsolete
>From c767f74264438cf28accf6b4faeb727be3cb2197 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 24 Oct 2022 11:17:48 +0000 >Subject: [PATCH] Bug 23012: (QA follow-up) No need to create and delete rules > for branch > >The tests create a new branch to make sure one exists without rules. We then add a rule >and delete it. We can simply create the new branch and never assign a rule > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Koha/CirculationRules.t | 51 +------------------------- > 1 file changed, 1 insertion(+), 50 deletions(-) > >diff --git a/t/db_dependent/Koha/CirculationRules.t b/t/db_dependent/Koha/CirculationRules.t >index c4009c6a96..18c8653523 100755 >--- a/t/db_dependent/Koha/CirculationRules.t >+++ b/t/db_dependent/Koha/CirculationRules.t >@@ -789,56 +789,7 @@ subtest 'get_lostreturn_policy() tests' => sub { > ); > > # Make sure we have an unused branchcode >- my $branchcode4 = $builder->build( { source => 'Branch' } )->{branchcode}; >- my $specific_lost_rule_dummy = $builder->build( >- { >- source => 'CirculationRule', >- value => { >- branchcode => $branchcode4, >- categorycode => undef, >- itemtype => undef, >- rule_name => 'lostreturn', >- rule_value => 'refund' >- } >- } >- ); >- my $specific_proc_rule_dummy = $builder->build( >- { >- source => 'CirculationRule', >- value => { >- branchcode => $branchcode4, >- categorycode => undef, >- itemtype => undef, >- rule_name => 'processingreturn', >- rule_value => 'refund' >- } >- } >- ); >- my $branch_without_rule = $specific_lost_rule_dummy->{ branchcode }; >- Koha::CirculationRules >- ->search( >- { >- branchcode => $branch_without_rule, >- categorycode => undef, >- itemtype => undef, >- rule_name => 'lostreturn', >- rule_value => 'refund' >- } >- ) >- ->next >- ->delete; >- Koha::CirculationRules >- ->search( >- { >- branchcode => $branch_without_rule, >- categorycode => undef, >- itemtype => undef, >- rule_name => 'processingreturn', >- rule_value => 'refund' >- } >- ) >- ->next >- ->delete; >+ my $branch_without_rule = $builder->build( { source => 'Branch' } )->{branchcode}; > > my $item = $builder->build_sample_item( > { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23012
:
141627
|
141628
|
141629
|
141630
|
142046
|
142047
|
142048
|
142049
|
142113
|
142123
|
142124
|
142125
|
142126
|
142481
|
142482
|
142483
|
142484
|
142485
| 142486 |
142487
|
142575
|
142652
|
142693
|
142736
|
142737