Attachment 142570 Details for Bug 31876 – Bug 31876: Fix capitalization "Click to Expand Tag"

[patch] Bug 31876: Fix capitalization "Click to Expand Tag"

Bug-31876-Fix-capitalization-Click-to-Expand-Tag.patch (text/plain), 6.64 KB, created by Caroline Cyr La Rose on 2022-10-24 21:11:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caroline Cyr La Rose

Created: 2022-10-24 21:11:53 UTC

Size: 6.64 KB

patch

obsolete

>From db23ee38f4906760ab6c24c57381a9d156ac9323 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Mon, 24 Oct 2022 20:32:27 +0000
>Subject: [PATCH] Bug 31876: Fix capitalization "Click to Expand Tag"
>
>The string "Click to Expand this Tag" appears in addbiblio.tt a couple of times. It should be "Click to expand this tag".
>
>To get to the string for the staff interface:
>1. In the staff interface, go to Cataloging
>2. Click "New record"
>3. Hover the mouse cursor over one of the tag titles (e.g. CONTROL NUMBER)
>   --> a little popup thing (tooltip?) appears with "Click to Expand this Tag"
>4. Go to Administration > Global system preferences
>5. Search for advancedMARCeditor
>6. Change the value to "Don't show"
>7. Click "Save all Cataloging preferences"
>8. Go back to Cataloging > New record
>9. Hover the mouse cursor over the tag number (e.g. 001)
>   --> a little popup thing (tooltip?) appears with "<tag title> Click to Expand this Tag"
>10. Go to Authorities > new record
>11. Hover over the desription of a tag which subfields are collapsed
>   --> verify the tooltip appears with "Click to Expand this Tag"
>12. Apply patch, all occurrences should be fixed now.
>
>https://bugs.koha-community.org/show_bug.cgi?id=31907
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>---
> .../intranet-tmpl/prog/en/modules/authorities/authorities.tt  | 4 ++--
> .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt    | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>index 1b068ded6d..fa15e77206 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>@@ -401,7 +401,7 @@
>                                                 <div class="tag_title" id="div_indicator_tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>                                                     [% UNLESS hide_marc %]
>                                                         [% IF advancedMARCEditor %]
>-                                                            <a href="#" tabindex="1" class="tagnum" title="[% innerloo.tag_lib | html %] - Click to Expand this Tag" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;">[% innerloo.tag | html %]</a>
>+                                                            <a href="#" tabindex="1" class="tagnum" title="[% innerloo.tag_lib | html %] - Click to expand this tag" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;">[% innerloo.tag | html %]</a>
>                                                         [% ELSE %]
>                                                             <span class="tagnum" title="[% innerloo.tag_lib | html %]">[% innerloo.tag | html %]</span>
>                                                         [% END %]
>@@ -461,7 +461,7 @@
>                                                     [% END # /UNLESS hide_marc %]
> 
>                                                     [% UNLESS advancedMARCEditor %]
>-                                                        <a href="#" tabindex="1" class="expandfield" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;" title="Click to Expand this Tag">[% innerloo.tag_lib | html %]</a>
>+                                                        <a href="#" tabindex="1" class="expandfield" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;" title="Click to expand this tag">[% innerloo.tag_lib | html %]</a>
>                                                     [% END %]
>                                                     <span class="field_controls">
>                                                         [% IF ( innerloo.repeatable ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index f16f5c8147..f97957a806 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -1038,7 +1038,7 @@ function PopupMARCFieldDoc(field) {
>                                         [% END %]
>                                             <div class="tag_title" id="div_indicator_tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>                                                 [% IF advancedMARCEditor %]
>-                                                    <a href="#" tabindex="1" class="tagnum" title="[% innerloo.tag_lib | html %] - Click to Expand this Tag" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;">[% innerloo.tag | html %]</a>
>+                                                    <a href="#" tabindex="1" class="tagnum" title="[% innerloo.tag_lib | html %] - Click to expand this tag" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;">[% innerloo.tag | html %]</a>
>                                                 [% ELSE %]
>                                                     <span class="tagnum" title="[% innerloo.tag_lib | html %]">[% innerloo.tag | html %]</span>
>                                                     <a href="#" class="marcdocs" onclick="PopupMARCFieldDoc('[% innerloo.tag | html %]'); return false;">&nbsp;?</a>
>@@ -1079,7 +1079,7 @@ function PopupMARCFieldDoc(field) {
>                                                 [% END # /IF innerloo.fixedfield %] -
> 
>                                                 [% UNLESS advancedMARCEditor %]
>-                                                    <a href="#" tabindex="1" class="expandfield" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;" title="Click to Expand this Tag">[% innerloo.tag_lib | html %]</a>
>+                                                    <a href="#" tabindex="1" class="expandfield" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;" title="Click to expand this tag">[% innerloo.tag_lib | html %]</a>
>                                                 [% END %]
> 
>                                                 <span class="field_controls">
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 31876: 142568 | 142570 | 142979