Attachment 142612 Details for Bug 31894 – Bug 31894: (QA follow-up) Move rollbacks to the end

[patch] Bug 31894: (QA follow-up) Move rollbacks to the end

Bug-31894-QA-follow-up-Move-rollbacks-to-the-end.patch (text/plain), 1.75 KB, created by Marcel de Rooy on 2022-10-25 14:30:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-10-25 14:30:29 UTC

Size: 1.75 KB

patch

obsolete

>From 51657186ddeba8bc268751acbc6f70bc3fdeb4d0 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 25 Oct 2022 14:29:35 +0000
>Subject: [PATCH] Bug 31894: (QA follow-up) Move rollbacks to the end
>Content-Type: text/plain; charset=utf-8
>
>Obvious fix. This test removed my method records.
>---
> t/db_dependent/Koha/Plugins/Holds_hooks.t | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Plugins/Holds_hooks.t b/t/db_dependent/Koha/Plugins/Holds_hooks.t
>index d1a9dba00d..d80d73c489 100755
>--- a/t/db_dependent/Koha/Plugins/Holds_hooks.t
>+++ b/t/db_dependent/Koha/Plugins/Holds_hooks.t
>@@ -80,8 +80,8 @@ subtest 'after_hold_create() hook tests' => sub {
>           qr/after_hold_create called with parameter Koha::Hold/ ],
>           'AddReserve calls the after_hold_create hook, deprecation warning found';
> 
>-    $schema->storage->txn_rollback;
>     Koha::Plugins::Methods->delete;
>+    $schema->storage->txn_rollback;
> };
> 
> subtest 'after_hold_action (placed) hook tests' => sub {
>@@ -124,8 +124,8 @@ subtest 'after_hold_action (placed) hook tests' => sub {
>     }
>     [ qr/after_hold_create is deprecated and will be removed soon/, qr/after_hold_action called with action: place, ref: Koha::Hold/,  ], 'AddReserve calls the after_hold_action hook';
> 
>-    $schema->storage->txn_rollback;
>     Koha::Plugins::Methods->delete;
>+    $schema->storage->txn_rollback;
> };
> 
> subtest 'Koha::Hold tests' => sub {
>@@ -205,6 +205,6 @@ subtest 'Koha::Hold tests' => sub {
>     qr/after_hold_action called with action: cancel, ref: Koha::Old::Hold/,
>       '->cancel calls the after_hold_action hook';
> 
>-    $schema->storage->txn_rollback;
>     Koha::Plugins::Methods->delete;
>+    $schema->storage->txn_rollback;
> };
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31894: 142265 | 142278 | 142612 | 142613 | 142747