Bugzilla – Attachment 142645 Details for
Bug 20817
Add ability to retain 9xx fields when adding on order item to existing record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20817: (QA follow-up) Fix POD for GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues
Bug-20817-QA-follow-up-Fix-POD-for-GetMarcFieldsTo.patch (text/plain), 2.08 KB, created by
Kyle M Hall
on 2022-10-25 16:33:23 UTC
(
hide
)
Description:
Bug 20817: (QA follow-up) Fix POD for GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2022-10-25 16:33:23 UTC
Size:
2.08 KB
patch
obsolete
>From 5784504b84d36e5ce3d975755e08c1c1005ce2f5 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Tue, 15 Mar 2022 11:38:51 -0400 >Subject: [PATCH] Bug 20817: (QA follow-up) Fix POD for > GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues > >--- > Koha/Acquisition/Utils.pm | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > >diff --git a/Koha/Acquisition/Utils.pm b/Koha/Acquisition/Utils.pm >index b78be6401f..c898a00f38 100644 >--- a/Koha/Acquisition/Utils.pm >+++ b/Koha/Acquisition/Utils.pm >@@ -31,12 +31,9 @@ Koha::Acquisition::Utils - Additional Koha functions for dealing with orders and > > my $data = Koha::Acquisition::Utils::GetMarcFieldsToOrderValues('MarcFieldsToOrder', $marcrecord, ['price', 'quantity', 'budget_code', etc.]); > >-This subroutine accepts a syspref ( MarcFieldsToOrder ), >-a marc record, and an arrayref of fields to retrieve. >- > The return value is a hashref of key value pairs, where the keys are the field list parameters, > and the values are extracted from the MARC record based on the key to MARC field mapping from the >-given system preference. >+system preference MarcFieldsToOrder. > > =cut > >@@ -71,12 +68,9 @@ sub GetMarcFieldsToOrderValues { > > my $data = GetMarcItemFieldsToOrderValues('MarcItemFieldsToOrder', $marcrecord, ['homebranch', 'holdingbranch', 'itype', 'nonpublic_note', 'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price', 'replacementprice', 'itemcallnumber', 'quantity', 'budget_code']); > >-This subroutine accepts a syspref ( MarcItemFieldsToOrder ), >-a marc record, and an arrayref of fields to retrieve. >- > The return value is a hashref of key value pairs, where the keys are the field list parameters, > and the values are extracted from the MARC record based on the key to MARC field mapping from the >-given system preference. >+system preference MarcFieldsToOrder. > > The largest difference between GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues is that the former deals > with singular marc fields, while the latter works on multiple matching marc fields and returns -1 if it cannot >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20817
:
79867
|
80537
|
86711
|
86746
|
105214
|
105215
|
105216
|
105217
|
105218
|
105219
|
115343
|
118371
|
118372
|
118373
|
118374
|
118375
|
118376
|
118377
|
118378
|
122692
|
122834
|
122841
|
122858
|
122861
|
128766
|
128767
|
128768
|
128769
|
128770
|
128771
|
128772
|
128773
|
128774
|
128775
|
128776
|
128777
|
128782
|
128783
|
128785
|
128786
|
128787
|
128788
|
128789
|
128790
|
128791
|
128792
|
128793
|
128794
|
128795
|
128796
|
128797
|
128798
|
131732
|
131733
|
131734
|
131735
|
131736
|
131737
|
131738
|
131739
|
131740
|
131741
|
131742
|
131743
|
131744
|
131745
|
131746
|
131747
|
131748
|
131749
|
142630
|
142631
|
142632
|
142633
|
142634
|
142635
|
142636
|
142637
|
142638
|
142639
|
142640
|
142641
|
142642
|
142643
|
142644
|
142645
|
142646
|
142647
|
142648
|
142649
|
142650
|
142651
|
142829