Bugzilla – Attachment 142712 Details for
Bug 31937
Prevent cleanup_database.pl from locking too many accounts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31937: Fix Patrons::search_unsubscribed - sharpen condition
Bug-31937-Fix-Patronssearchunsubscribed---sharpen-.patch (text/plain), 1.19 KB, created by
Marcel de Rooy
on 2022-10-27 12:00:37 UTC
(
hide
)
Description:
Bug 31937: Fix Patrons::search_unsubscribed - sharpen condition
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-10-27 12:00:37 UTC
Size:
1.19 KB
patch
obsolete
>From d6f30daa26d02272f2897e8537203c19e9f59640 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 26 Oct 2022 15:00:53 +0000 >Subject: [PATCH] Bug 31937: Fix Patrons::search_unsubscribed - sharpen > condition >Content-Type: text/plain; charset=utf-8 > >The condition is fine as long as we only have GDPR consents. >But if you dont, you would have trouble. I know :) >Lets prevent that here, although the table still has an ENUM. So >double safety. > >Test plan: >Run t/db_dependent/Koha/Patrons.t >Bonus: Run cleanup_database.pl and check for unusual number of >locked accounts: > misc/cronjobs/cleanup_database.pl --confirm -v --sessions > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Patrons.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/Koha/Patrons.pm b/Koha/Patrons.pm >index caf6d4a251..d5743c1bf8 100644 >--- a/Koha/Patrons.pm >+++ b/Koha/Patrons.pm >@@ -237,6 +237,7 @@ sub search_unsubscribed { > return $class->search( > { > 'patron_consents.refused_on' => { '<=' => $str }, >+ 'patron_consents.type' => 'GDPR_PROCESSING', > 'login_attempts' => $cond, > }, > { join => 'patron_consents' }, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31937
:
142712
|
143979
|
143980
|
143982