Attachment 142833 Details for Bug 24606 – Bug 24606: (QA follow-up) Fix QA script issues

[patch] Bug 24606: (QA follow-up) Fix QA script issues

Bug-24606-QA-follow-up-Fix-QA-script-issues.patch (text/plain), 2.61 KB, created by Kyle M Hall (khall) on 2022-10-31 15:38:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-10-31 15:38:14 UTC

Size: 2.61 KB

patch

obsolete

>From 5371995abe482ea797533b57d117954b45c6560f Mon Sep 17 00:00:00 2001
>From: Kyle Hall <kyle@bywatersolutions.com>
>Date: Mon, 31 Oct 2022 09:05:57 -0400
>Subject: [PATCH] Bug 24606: (QA follow-up) Fix QA script issues
>
>---
> Koha/Item/Templates.pm                          |  2 ++
> Koha/Schema/Result/ItemEditorTemplate.pm        | 17 +++++++++++++++++
> .../prog/en/modules/cataloguing/additem.tt      |  2 +-
> 3 files changed, 20 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Item/Templates.pm b/Koha/Item/Templates.pm
>index 2ebe3c8e28..9c635f9bd1 100644
>--- a/Koha/Item/Templates.pm
>+++ b/Koha/Item/Templates.pm
>@@ -28,6 +28,8 @@ use base qw(Koha::Objects);
> 
> Koha::Item::Templates - Koha Item Template Object set class
> 
>+=head2 METHODS
>+
> =head3 get_available
> 
> Returns a hashref with keys 'owned' and 'shared' pointing to Koha::Item::Templats objects
>diff --git a/Koha/Schema/Result/ItemEditorTemplate.pm b/Koha/Schema/Result/ItemEditorTemplate.pm
>index 5ac366c172..0f34cebf1d 100644
>--- a/Koha/Schema/Result/ItemEditorTemplate.pm
>+++ b/Koha/Schema/Result/ItemEditorTemplate.pm
>@@ -114,9 +114,26 @@ __PACKAGE__->belongs_to(
> # Created by DBIx::Class::Schema::Loader v0.07049 @ 2022-09-28 16:49:35
> # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:7JIe4z78F9oMOAnAZdqmtA
> 
>+__PACKAGE__->add_columns(
>+    '+is_shared' => { is_boolean => 1 },
>+);
>+
>+=head2 koha_object_class
>+
>+  Koha Object class
>+
>+=cut
>+
> sub koha_object_class {
>     'Koha::Item::Template';
> }
>+
>+=head2 koha_objects_class
>+
>+  Koha Objects class
>+
>+=cut
>+
> sub koha_objects_class {
>     'Koha::Item::Templates';
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>index af38c482be..0f180caf69 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>@@ -272,7 +272,7 @@
>             <option value="0" selected="selected">Save as new template</option>
>             <optgroup label="Update existing template">
>                 [% FOREACH t IN item_templates.owned %]
>-                    <option data-editor="1" data-shared="[% t.is_shared %]" value="[% t.id | html %]">[% t.name | html %][% IF t.is_shared %] (shared)[% END %]</option>
>+                    <option data-editor="1" data-shared="[% t.is_shared | html %]" value="[% t.id | html %]">[% t.name | html %][% IF t.is_shared %] (shared)[% END %]</option>
>                 [% END %]
>                 [% IF CAN_user_editcatalogue_manage_item_editor_templates && item_templates.shared.count %]
>                     <optgroup label="Update shared template">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 24606: 141613 | 141614 | 141615 | 141616 | 141617 | 141717 | 141718 | 141719 | 141720 | 141721 | 141972 | 142003 | 142004 | 142005 | 142006 | 142007 | 142008 | 142833 | 142834 | 142835 | 142836 | 142837 | 142877 | 142878 | 142879 | 142880 | 142881 | 142882 | 142883 | 142884 | 142885 | 142886 | 142887 | 142888 | 143020 | 143569 | 143570 | 143571 | 143572 | 143573 | 143574 | 143575 | 143576 | 143577 | 143578 | 143579 | 143580 | 143581 | 143794 | 143795 | 143796 | 143989 | 143990 | 144161