Attachment 142957 Details for Bug 24860 – Bug 24860: Implement reserves.item_group_id

[patch] Bug 24860: Implement reserves.item_group_id

Bug-24860-Implement-reservesitemgroupid.patch (text/plain), 3.35 KB, created by Kyle M Hall (khall) on 2022-11-02 13:14:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-11-02 13:14:00 UTC

Size: 3.35 KB

patch

obsolete

>From 43b47bdf3ab01204c709afc9737dc915e6d4fb6f Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 28 Feb 2020 14:45:44 -0500
>Subject: [PATCH] Bug 24860: Implement reserves.item_group_id
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>
>Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
>---
> C4/Reserves.pm                       | 2 ++
> Koha/REST/V1/Holds.pm                | 2 ++
> api/v1/swagger/definitions/hold.yaml | 5 +++++
> api/v1/swagger/paths/holds.yaml      | 9 +++++++++
> 4 files changed, 18 insertions(+)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index a03072d8df..c70a069efe 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -192,6 +192,7 @@ sub AddReserve {
>     my $found          = $params->{found};
>     my $itemtype       = $params->{itemtype};
>     my $non_priority   = $params->{non_priority};
>+    my $item_group_id  = $params->{item_group_id};
> 
>     $resdate ||= dt_from_string;
> 
>@@ -240,6 +241,7 @@ sub AddReserve {
>         {
>             borrowernumber => $borrowernumber,
>             biblionumber   => $biblionumber,
>+            item_group_id  => $item_group_id,
>             reservedate    => $resdate,
>             branchcode     => $branch,
>             priority       => $priority,
>diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm
>index 44188363a6..afd62badca 100644
>--- a/Koha/REST/V1/Holds.pm
>+++ b/Koha/REST/V1/Holds.pm
>@@ -70,6 +70,7 @@ sub add {
>         my $item;
> 
>         my $biblio_id         = $body->{biblio_id};
>+        my $item_group_id     = $body->{item_group_id};
>         my $pickup_library_id = $body->{pickup_library_id};
>         my $item_id           = $body->{item_id};
>         my $patron_id         = $body->{patron_id};
>@@ -197,6 +198,7 @@ sub add {
>                 found            => undef,                # TODO: Why not?
>                 itemtype         => $item_type,
>                 non_priority     => $non_priority,
>+                item_group_id    => $item_group_id,
>             }
>         );
> 
>diff --git a/api/v1/swagger/definitions/hold.yaml b/api/v1/swagger/definitions/hold.yaml
>index 1ca8114cf3..2c5ac09f8d 100644
>--- a/api/v1/swagger/definitions/hold.yaml
>+++ b/api/v1/swagger/definitions/hold.yaml
>@@ -16,6 +16,11 @@ properties:
>   biblio_id:
>     type: integer
>     description: Internal biblio identifier
>+  item_group_id:
>+    type:
>+      - string
>+      - "null"
>+    description: Internal item_group identifier
>   pickup_library_id:
>     type:
>       - string
>diff --git a/api/v1/swagger/paths/holds.yaml b/api/v1/swagger/paths/holds.yaml
>index 7ab45af5b7..f63ce0c017 100644
>--- a/api/v1/swagger/paths/holds.yaml
>+++ b/api/v1/swagger/paths/holds.yaml
>@@ -24,6 +24,10 @@
>         in: query
>         description: Internal biblio identifier
>         type: integer
>+      - name: item_group_id
>+        in: query
>+        description: Internal item group identifier
>+        type: integer
>       - name: pickup_library_id
>         in: query
>         description: Internal library identifier for the pickup library
>@@ -140,6 +144,11 @@
>               type:
>                 - integer
>                 - "null"
>+            item_group_id:
>+              description: Internal item group identifier
>+              type:
>+                - integer
>+                - "null"
>             hold_date:
>               description: The date the hold was placed
>               type:
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 24860: 100644 | 100645 | 100646 | 100647 | 100648 | 100649 | 100650 | 100651 | 101744 | 101745 | 101746 | 101747 | 101748 | 101749 | 101750 | 101751 | 101827 | 101828 | 101829 | 101830 | 101831 | 101832 | 101833 | 101834 | 101835 | 102230 | 102231 | 102232 | 102233 | 102234 | 102235 | 102236 | 102237 | 102238 | 102239 | 102240 | 102241 | 102242 | 102243 | 102244 | 102245 | 102246 | 102247 | 106589 | 106590 | 106591 | 106592 | 106593 | 106594 | 106595 | 106596 | 106597 | 106682 | 106683 | 106684 | 106685 | 106686 | 106687 | 106688 | 106689 | 106690 | 106742 | 106743 | 106744 | 106745 | 106746 | 106747 | 106748 | 106749 | 106750 | 108458 | 108459 | 108460 | 108461 | 108462 | 108463 | 108464 | 108465 | 108466 | 109097 | 109098 | 109099 | 109100 | 109101 | 109102 | 109103 | 109104 | 109105 | 109171 | 109172 | 109173 | 109174 | 109175 | 109176 | 109177 | 109178 | 109179 | 113616 | 113617 | 113618 | 113619 | 113620 | 113621 | 113622 | 113623 | 113624 | 135922 | 135923 | 135924 | 135925 | 135926 | 135927 | 135928 | 135929 | 135930 | 138221 | 138222 | 138224 | 138225 | 138226 | 138227 | 138228 | 138229 | 138230 | 141214 | 141215 | 141735 | 141736 | 141737 | 141738 | 141739 | 141740 | 141741 | 141742 | 141743 | 141744 | 141745 | 141746 | 141747 | 141748 | 141749 | 141750 | 142413 | 142414 | 142415 | 142416 | 142417 | 142418 | 142419 | 142420 | 142421 | 142422 | 142423 | 142424 | 142425 | 142426 | 142427 | 142428 | 142429 | 142430 | 142827 | 142955 | 142956 | 142957 | 142958 | 142959 | 142960 | 142961 | 142962 | 142963 | 142964 | 142965 | 142966 | 142967 | 142968 | 142969 | 142970 | 142971 | 142972 | 142973 | 142974 | 142975 | 142992 | 142993 | 142994 | 142995 | 142996 | 142997 | 142998 | 142999 | 143000 | 143001 | 143002 | 143003 | 143004 | 143005 | 143006 | 143007 | 143008 | 143009 | 143010 | 143011