Attachment 14297 Details for Bug 9325 – Bug 9325: Fix overdue letter generation

[patch] Bug 9325: Fix overdue letter generation

Bug-9325-Fix-overdue-letter-generation.patch (text/plain), 1.20 KB, created by Jonathan Druart on 2012-12-27 15:46:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2012-12-27 15:46:41 UTC

Size: 1.20 KB

patch

obsolete

>From 917e161d663c90591e3a8adc3b594803fc0280dc Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Thu, 13 Dec 2012 11:50:57 +0100
>Subject: [PATCH] Bug 9325: Fix overdue letter generation
>
>In overdue_notices.pl, letter template must not be passed to
>parse_letter because this sub modifies it, so the first overdue letter
>is ok but following letters have exactly the same content.
>This patch make a copy of the template before passing it to parse_letter
>---
> misc/cronjobs/overdue_notices.pl |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
>index 737fa34..dab4019 100755
>--- a/misc/cronjobs/overdue_notices.pl
>+++ b/misc/cronjobs/overdue_notices.pl
>@@ -509,7 +509,7 @@ END_SQL
> 
>                 my $letter = parse_letter(
>                     {   letter_code     => $overdue_rules->{"letter$i"},
>-                        letter          => $letter_template,
>+                        letter          => { %$letter_template },
>                         borrowernumber  => $borrowernumber,
>                         branchcode      => $branchcode,
>                         items           => \@items,
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 9325: 14297 | 14420