Attachment 143020 Details for Bug 24606 – Bug 24606: (QA follow-up) Fix up save form a bit

[patch] Bug 24606: (QA follow-up) Fix up save form a bit

Bug-24606-QA-follow-up-Fix-up-save-form-a-bit.patch (text/plain), 4.51 KB, created by Kyle M Hall (khall) on 2022-11-02 17:15:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-11-02 17:15:35 UTC

Size: 4.51 KB

patch

obsolete

>From 054002c100976b5663f4b8cb1ffb030b75f591f3 Mon Sep 17 00:00:00 2001
>From: Kyle Hall <kyle@bywatersolutions.com>
>Date: Wed, 2 Nov 2022 13:15:17 -0400
>Subject: [PATCH] Bug 24606: (QA follow-up) Fix up save form a bit
>
>---
> .../prog/en/modules/cataloguing/additem.tt    | 60 +++++++++++--------
> 1 file changed, 34 insertions(+), 26 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>index f0242bd8e3..6aa78b3e0b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>@@ -278,35 +278,43 @@
>     </span>
>     <fieldset id="save_as_template_span">
>         <legend>Save template</legend>
>-        <select name="replace_template_id" id="replace_template_id" class="select2" style="width: 20em">
>-            <option value="0" selected="selected">Save as new template</option>
>-            <optgroup label="Update existing template">
>-                [% FOREACH t IN item_templates.owned %]
>-                    <option data-editor="1" data-shared="[% t.is_shared | html %]" value="[% t.id | html %]">[% t.name | html %][% IF t.is_shared %] (shared)[% END %]</option>
>-                [% END %]
>-                [% IF CAN_user_editcatalogue_manage_item_editor_templates && item_templates.shared.count %]
>-                    <optgroup label="Update shared template">
>-                        [% FOREACH t IN item_templates.shared %]
>-                            <option data-editor="1" data-shared="1" value="[% t.id | html %]">[% t.name | html %][% IF t.is_shared %] (shared)[% END %]</option>
>-                        [% END %]
>-                    </optgroup>
>-                [% END %]
>-            </optgroup>
>-        </select>
>+        <div class="btn-group">
>+            <select name="replace_template_id" id="replace_template_id" class="select2" style="width: 20em">
>+                <option value="0" selected="selected">Save as new template</option>
>+                <optgroup label="Update existing template">
>+                    [% FOREACH t IN item_templates.owned %]
>+                        <option data-editor="1" data-shared="[% t.is_shared | html %]" value="[% t.id | html %]">[% t.name | html %][% IF t.is_shared %] (shared)[% END %]</option>
>+                    [% END %]
>+                    [% IF CAN_user_editcatalogue_manage_item_editor_templates && item_templates.shared.count %]
>+                        <optgroup label="Update shared template">
>+                            [% FOREACH t IN item_templates.shared %]
>+                                <option data-editor="1" data-shared="1" value="[% t.id | html %]">[% t.name | html %][% IF t.is_shared %] (shared)[% END %]</option>
>+                            [% END %]
>+                        </optgroup>
>+                    [% END %]
>+                </optgroup>
>+            </select>
>+        </div>
> 
>-        <span id="template_name_block">
>-            <label for="template_name" class="required">Template name: </label>
>-            <input type="text" id="template_name" name="template_name" class="required"/>
>-            <span class="required">Required</span>
>-        </span>
>+        <div class="btn-group">
>+            <span id="template_name_block">
>+                <label for="template_name" class="required">Template name: </label>
>+                <input type="text" id="template_name" name="template_name" class="required"/>
>+                <span class="required">Required</span>
>+            </span>
>+        </div>
> 
>-        <label for="template_is_shared">
>-            <input type="checkbox" id="template_is_shared" name="template_is_shared"/>
>-            Share template
>-        </label>
>+        <div class="btn-group">
>+            <label for="template_is_shared">
>+                <input type="checkbox" id="template_is_shared" name="template_is_shared"/>
>+                Share template
>+            </label>
>+        </div>
> 
>-        <input type="submit" id="save_as_template_submit" name="save_as_template_submit" value="Save" onclick="javascript:return CheckTemplateForm(this.form);" />
>-        <a href="#" id="cancel_save_as_template" class="cancel">Cancel</a>
>+        <div class="btn-group">
>+            <input type="submit" id="save_as_template_submit" name="save_as_template_submit" value="Save" onclick="javascript:return CheckTemplateForm(this.form);" />
>+            <a href="#" id="cancel_save_as_template" class="cancel">Cancel</a>
>+        </div>
>     </fieldset>
> 
>     [% ELSE %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 24606: 141613 | 141614 | 141615 | 141616 | 141617 | 141717 | 141718 | 141719 | 141720 | 141721 | 141972 | 142003 | 142004 | 142005 | 142006 | 142007 | 142008 | 142833 | 142834 | 142835 | 142836 | 142837 | 142877 | 142878 | 142879 | 142880 | 142881 | 142882 | 142883 | 142884 | 142885 | 142886 | 142887 | 142888 | 143020 | 143569 | 143570 | 143571 | 143572 | 143573 | 143574 | 143575 | 143576 | 143577 | 143578 | 143579 | 143580 | 143581 | 143794 | 143795 | 143796 | 143989 | 143990 | 144161