Attachment 143033 Details for Bug 15869 – Bug 15869: (follow-up) Don't mock undef return value

[patch] Bug 15869: (follow-up) Don't mock undef return value

Bug-15869-follow-up-Dont-mock-undef-return-value.patch (text/plain), 1.00 KB, created by Nick Clemens (kidclamp) on 2022-11-02 19:34:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-11-02 19:34:08 UTC

Size: 1.00 KB

patch

obsolete

>From 64df5e867faa4bd82bf0f6f13e26d68756e8ffb5 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 2 Nov 2022 19:27:38 +0000
>Subject: [PATCH] Bug 15869: (follow-up) Don't mock undef return value
>
>---
> t/db_dependent/ImportBatch.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/ImportBatch.t b/t/db_dependent/ImportBatch.t
>index a745861bd6..1ff0eddd33 100755
>--- a/t/db_dependent/ImportBatch.t
>+++ b/t/db_dependent/ImportBatch.t
>@@ -333,7 +333,7 @@ subtest "BatchCommitRecords overlay into framework" => sub {
>     t::lib::Mocks::mock_config( 'enable_plugins', 0 );
>     my $mock_import = Test::MockModule->new("C4::ImportBatch");
>     my $biblio = $builder->build_sample_biblio;
>-    $mock_import->mock( _get_commit_action => sub { return ('replace',undef,$biblio->biblionumber); } );
>+    $mock_import->mock( _get_commit_action => sub { return ('replace','ignore',$biblio->biblionumber); } );
> 
>     my $import_batch = {
>         matcher_id => 2,
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 15869: 55543 | 70800 | 77018 | 140857 | 140858 | 142257 | 142258 | 143033 | 145271 | 145272 | 145273 | 145274 | 145406