Bugzilla – Attachment 143053 Details for
Bug 30358
Strip leading/trailing whitespace characters from input fields when cataloguing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30358: (follow-up) Fixing ModBiblioMarc.t tests
Bug-30358-follow-up-Fixing-ModBiblioMarct-tests.patch (text/plain), 1.91 KB, created by
Aleisha Amohia
on 2022-11-03 01:13:02 UTC
(
hide
)
Description:
Bug 30358: (follow-up) Fixing ModBiblioMarc.t tests
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2022-11-03 01:13:02 UTC
Size:
1.91 KB
patch
obsolete
>From ed044430a16dfbf950fb34c59d7e9d273d5305e8 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Thu, 3 Nov 2022 01:12:11 +0000 >Subject: [PATCH] Bug 30358: (follow-up) Fixing ModBiblioMarc.t tests > >--- > C4/Biblio.pm | 1 + > t/db_dependent/Biblio/ModBiblioMarc.t | 6 ++++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 10299c2c352..71000916a6a 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -113,6 +113,7 @@ use Koha::SearchEngine; > use Koha::SearchEngine::Indexer; > use Koha::Libraries; > use Koha::Util::MARC; >+use Koha::MetadataRecord; > > =head1 NAME > >diff --git a/t/db_dependent/Biblio/ModBiblioMarc.t b/t/db_dependent/Biblio/ModBiblioMarc.t >index 5e33cd23e24..e049598da94 100755 >--- a/t/db_dependent/Biblio/ModBiblioMarc.t >+++ b/t/db_dependent/Biblio/ModBiblioMarc.t >@@ -63,14 +63,16 @@ subtest "StripWhitespaceChars tests" => sub { > is( $title, " My\ntitle\n", 'Title has whitespace characters' ); > > C4::Biblio::ModBiblioMarc( $record, $biblio->biblionumber ); >- my $savedrec = C4::Biblio::GetMarcBiblio({ biblionumber => $biblio->biblionumber }); >+ $biblio = Koha::Biblios->find( $biblio->biblionumber ); >+ my $savedrec = $biblio->metadata->record; > my $savedtitle = $savedrec->title; > is( $savedtitle, " My\ntitle\n", "Title still has whitespace characters because StripWhitespaceChars is disabled" ); > > t::lib::Mocks::mock_preference('StripWhitespaceChars', 1); > > C4::Biblio::ModBiblioMarc( $record, $biblio->biblionumber ); >- my $amendedrec = C4::Biblio::GetMarcBiblio({ biblionumber => $biblio->biblionumber }); >+ $biblio = Koha::Biblios->find( $biblio->biblionumber ); >+ my $amendedrec = $biblio->metadata->record; > my $amendedtitle = $amendedrec->title; > is( $amendedtitle, "My title", "Whitespace characters removed from title because StripWhitespaceChars is enabled" ); > }; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30358
:
132202
|
132275
|
132919
|
133055
|
133056
|
133140
|
133224
|
133225
|
134195
|
134453
|
137451
|
137452
|
137453
|
137454
|
137455
|
137456
|
137457
|
139110
|
142905
|
142906
|
142907
|
142908
|
142909
|
142910
|
142911
|
142912
|
143053
|
143057
|
143058
|
143059
|
143060
|
143061
|
143062
|
143063
|
143064
|
143065
|
144120
|
144121
|
144122
|
144123
|
144124
|
144125
|
144126
|
144127
|
144128
|
144129
|
144130
|
144171
|
145308
|
145309
|
145310
|
145311
|
145312
|
145313
|
145314
|
145315
|
145316
|
145317
|
145318
|
151202
|
151203
|
151204
|
151205
|
151206
|
151207
|
151208
|
151210
|
151212
|
151214
|
151215