Attachment 143171 Details for Bug 31896 – Bug 31896: (QA follow-up) Fix rollback

[patch] Bug 31896: (QA follow-up) Fix rollback

Bug-31896-QA-follow-up-Fix-rollback.patch (text/plain), 1.04 KB, created by Marcel de Rooy on 2022-11-04 09:26:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-11-04 09:26:18 UTC

Size: 1.04 KB

patch

obsolete

>From b981b40ccf60f651421768ed0b2070b6011818af Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 28 Oct 2022 08:45:02 +0000
>Subject: [PATCH] Bug 31896: (QA follow-up) Fix rollback
>Content-Type: text/plain; charset=utf-8
>
>Yes, it should be the last statement.
>Actually the preceding delete is unneeded.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Koha/Plugins/Recall_hooks.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Plugins/Recall_hooks.t b/t/db_dependent/Koha/Plugins/Recall_hooks.t
>index ee8acbcc8b..19624f1211 100755
>--- a/t/db_dependent/Koha/Plugins/Recall_hooks.t
>+++ b/t/db_dependent/Koha/Plugins/Recall_hooks.t
>@@ -95,6 +95,6 @@ subtest 'after_recall_action hook' => sub {
>     qr/after_recall_action called with action: add, ref: Koha::Recall/,
>       '->add_recall calls the after_recall_action hook with action add';
> 
>-    $schema->storage->txn_rollback;
>     Koha::Plugins::Methods->delete;
>+    $schema->storage->txn_rollback;
> };
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31896: 142267 | 142279 | 142307 | 142331 | 142757 | 142758 | 142759 | 143169 | 143170 | 143171