Bugzilla – Attachment 143185 Details for
Bug 32111
Cannot schedule a pickup at the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32111: Remove disabled from date input for curbside pickup
Bug-32111-Remove-disabled-from-date-input-for-curb.patch (text/plain), 2.65 KB, created by
Owen Leonard
on 2022-11-04 12:43:26 UTC
(
hide
)
Description:
Bug 32111: Remove disabled from date input for curbside pickup
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-11-04 12:43:26 UTC
Size:
2.65 KB
patch
obsolete
>From 0e5db4c29de28c664db87ddcc762344e0f0d6080 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 4 Nov 2022 13:30:24 +0100 >Subject: [PATCH] Bug 32111: Remove disabled from date input for curbside > pickup > >The date input is always disabled and it's not possible to select or enter a date. > >git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true" > >I don't really know what's happening here, but it's impossible to >interact with the date widget if the input is disabled when it's >initialized. > >The solution I have here is to play with hide/show instead of disabled. > >Other suggestions welcome. > >Test plan: >Schedule a curbside pickup from the OPAC and confirm that the date input >is working as expected. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../bootstrap/en/modules/opac-curbside-pickups.tt | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >index 3760c79b30..26b892d198 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >@@ -243,7 +243,7 @@ > </li> > <li id="pickup_date_item"> > <label for="pickup-date">Pickup date:</label> >- <input name="pickup_date" type="text" class="flatpickr" id="pickup-date" disabled required="required"/> >+ <input name="pickup_date" type="text" class="flatpickr" id="pickup-date" required="required"/> > <div class="required_label required">Required</div> > </li> > >@@ -343,12 +343,10 @@ > > if (existing_pickup) { > $('#existing-pickup-warning').show(); >- $("#pickup_date_item,#pickup_notes_item").hide(); >- $('#pickup-date').prop("disabled", true); >+ $("#pickup-date,#pickup_date_item,#pickup_notes_item").hide(); > } else { > $('#existing-pickup-warning').hide(); >- $("#pickup_date_item").show(); >- $('#pickup-date').prop("disabled", branchcode == ""); >+ $("#pickup-date,#pickup_date_item").show(); > } > }); > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32111
:
143181
|
143184
|
143185
|
143492