Bugzilla – Attachment 14333 Details for
Bug 9309
"OPACurlOpenInNewWindow" isn't respected for 856$u links shown in OPAC when not using XSLT
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u
SIGNED-OFF-Bug-9309---Make-OPACurlOpenInNewWindow-.patch (text/plain), 2.08 KB, created by
Owen Leonard
on 2012-12-31 13:32:25 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-12-31 13:32:25 UTC
Size:
2.08 KB
patch
obsolete
>From 8cbc68b413bde5f4c17ed05b9d98ad6c4f81edee Mon Sep 17 00:00:00 2001 >From: Robin Sheat <robin@catalyst.net.nz> >Date: Thu, 20 Dec 2012 15:45:33 +1300 >Subject: [PATCH] [SIGNED-OFF] Bug 9309 - Make OPACurlOpenInNewWindow be > respected for 856$u >Content-Type: text/plain; charset="utf-8" > >If a biblio record contained a URL, and the OPAC was using the "normal" >(non-XSLT) display for records, then these links would never open a new >window. With this patch, they will. > >Test plan: >1) have a biblio containing an 856$u link >2) set OPACurlOpenInNewWindow to "true" >3) do not use XSLT for displaying the detail pages in the OPAC >4) view the record, click the link, and note that it opens in the > current window. >5) apply the patch >6) reload the detail page, click the link, and note that it opens a new > window. > >Sponsored-By: National Institute of Water and Atmospheric Research >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index fa5ec3d..bee65c2 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -479,7 +479,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > <br />[% END %] > <!-- here you might do a tmpl_if name="toc" and use greybox or equivalent for table of contents --> > >- [% IF ( MARCurl.OPACurlOpenInNewWindow ) %]<a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]" target="_blank">[% ELSE %]<a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]">[% END %] >+ [% IF ( OPACURLOpenInNewWindow ) %]<a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]" target="_blank">[% ELSE %]<a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]">[% END %] > > [% MARCurl.linktext %]</a> > [% IF ( MARCurl.notes ) %]<ul>[% FOREACH note IN MARCurl.notes %]<li>[% note.note %]</li>[% END %]</ul>[% END %]</li> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9309
:
14206
|
14207
|
14330
|
14333
|
14567