Attachment 143372 Details for Bug 32122 – Bug 32122: Correct permissions check on item circulation alerts

[patch] Bug 32122: Correct permissions check on item circulation alerts

Bug-32122-Correct-permissions-check-on-item-circul.patch (text/plain), 1.35 KB, created by Tomás Cohen Arazi (tcohen) on 2022-11-07 14:18:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-11-07 14:18:39 UTC

Size: 1.35 KB

patch

obsolete

>From 5d60b72bcc0d37146ad346ca3bbbabab807a4601 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 7 Nov 2022 13:54:58 +0000
>Subject: [PATCH] Bug 32122: Correct permissions check on item circulation
> alerts
>
>This patch changes the check from 'item_circ_alerts' to 'manage_item_circ_alerts'
>
>To test:
>1 - Give an account catalogue and manage_item_circ_alerts permissions
>2 - Log in to staff client iwht this account
>3 - Browse to Admin->Item circulation alerts
>4 - Error, you do not have permission to view this page
>5 - Apply patch
>6 - Restart all
>7 - Browse to page agian, success!
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> admin/item_circulation_alerts.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/item_circulation_alerts.pl b/admin/item_circulation_alerts.pl
>index 57a3c7d1233..8e79982928e 100755
>--- a/admin/item_circulation_alerts.pl
>+++ b/admin/item_circulation_alerts.pl
>@@ -41,7 +41,7 @@ sub show {
>             template_name   => "admin/item_circulation_alerts.tt",
>             query           => $input,
>             type            => "intranet",
>-            flagsrequired   => { parameters => 'item_circ_alerts' },
>+            flagsrequired   => { parameters => 'manage_item_circ_alerts' },
>             debug           => defined($input->param('debug')),
>         }
>     );
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 32122: 143370 | 143372