Attachment 143392 Details for Bug 31908 – Bug 31908: Resolve second login with another userid

[patch] Bug 31908: Resolve second login with another userid

Bug-31908-Resolve-second-login-with-another-userid.patch (text/plain), 1.19 KB, created by Marcel de Rooy on 2022-11-08 13:43:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-11-08 13:43:52 UTC

Size: 1.19 KB

patch

obsolete

>From f26183cd6371724603058f09e7110199ffc74754 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 8 Nov 2022 13:40:17 +0000
>Subject: [PATCH] Bug 31908: Resolve second login with another userid
>Content-Type: text/plain; charset=utf-8
>
>Somewhere the line undef $userid got removed.
>We need it to resolve the second login situation.
>
>Test plan:
>Login in staff with user missing privileges.
>On the login form login again with another staff user.
>Note that you do no longer crash.
>
>Run t/db../Auth.t
>Run t/db../Koha/Auth/TwoFactorAuth.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Auth.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index 8bd13e88e1..ec99a66cb8 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -903,6 +903,7 @@ sub checkauth {
>                 $cookie = $cookie_mgr->clear_unless( $query->cookie, @$cookie );
>                 C4::Context::_unset_userenv($sessionID);
>                 $sessionID = undef;
>+                undef $userid; # IMPORTANT: this assures us a new session in code below
>             } elsif (!$logout) {
> 
>                 $cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie(
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31908: 142361 | 143392 | 143491 | 143786 | 143819 | 143820 | 143821 | 143822 | 143884 | 143885 | 143886 | 143887 | 145092 | 145093 | 145250 | 145251 | 145252