Attachment 143444 Details for Bug 31902 – Bug 31902: Next header row inside a thead

[patch] Bug 31902: Next header row inside a thead

Bug-31902-Next-header-row-inside-a-thead.patch (text/plain), 2.52 KB, created by Martin Renvoize (ashimema) on 2022-11-08 15:52:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-11-08 15:52:22 UTC

Size: 2.52 KB

patch

obsolete

>From 830de8bff0f5704bab98a5f90b7a9257252bf1fa Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 8 Nov 2022 15:51:15 +0000
>Subject: [PATCH] Bug 31902: Next header row inside a thead
>
>This sets the proper markup for table headers in the holds page and thus
>grabs the proper header row underline.
>---
> .../prog/en/includes/holds_table.inc          | 42 ++++++++++---------
> 1 file changed, 22 insertions(+), 20 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>index 940e3040ca..d5b9a67a4f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>@@ -2,27 +2,29 @@
> [% SET hold_cancellation = AuthorisedValues.GetAuthValueDropbox('HOLD_CANCELLATION') %]
> [% USE AuthorisedValues %]
> <table class="holds_table">
>-    <tr>
>-        <th><input type="checkbox" class="select_hold_all"/></th>
>-        <th>Priority</th>
>-        [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %]
>+    <thead>
>+        <tr>
>+            <th><input type="checkbox" class="select_hold_all"/></th>
>+            <th>Priority</th>
>+            [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %]
>+                <th>&nbsp;</th>
>+            [% END %]
>+            <th>Patron</th>
>+            <th>Notes</th>
>+            <th>Date</th>
>+            <th>Expiration</th>
>+            <th>Pickup library</th>
>+            <th>Details</th>
>+            [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %]
>+                <th>
>+                    <i class="fa fa-lg fa-rotate-90 fa-fast-forward" title="Toggle set to lowest priority"></i>
>+                </th>
>+            [% END %]
>             <th>&nbsp;</th>
>-        [% END %]
>-        <th>Patron</th>
>-        <th>Notes</th>
>-        <th>Date</th>
>-        <th>Expiration</th>
>-        <th>Pickup library</th>
>-        <th>Details</th>
>-        [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %]
>-            <th>
>-                <i class="fa fa-lg fa-rotate-90 fa-fast-forward" title="Toggle set to lowest priority"></i>
>-            </th>
>-        [% END %]
>-        <th>&nbsp;</th>
>-        <th>&nbsp;</th>
>-        <th>Print hold/transfer slip</th>
>-    </tr>
>+            <th>&nbsp;</th>
>+            <th>Print hold/transfer slip</th>
>+        </tr>
>+    </thead>
>     [%- SET first_priority = 0 -%]
>     [%- SET found_holds = 0 -%]
>     [%- SET last_priority  = holds.last.priority -%]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 31902: 143444 | 143494