Attachment 14347 Details for Bug 9174 – Bug 9174 follow-up: Eliminate warning and fix POD

[patch] Bug 9174 follow-up: Eliminate warning and fix POD

Bug-9174-follow-up-Eliminate-warning-and-fix-POD.patch (text/plain), 1.17 KB, created by Jared Camins-Esakov on 2013-01-01 00:56:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jared Camins-Esakov

Created: 2013-01-01 00:56:17 UTC

Size: 1.17 KB

patch

obsolete

>From bf89e402666bffc18199535858c621fb46ff7cbe Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Mon, 31 Dec 2012 19:52:49 -0500
>Subject: [PATCH] Bug 9174 follow-up: Eliminate warning and fix POD
>
>Thanks to Marcel for spotting these issues.
>---
> C4/Koha.pm |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Koha.pm b/C4/Koha.pm
>index 2949b03..84aa898 100644
>--- a/C4/Koha.pm
>+++ b/C4/Koha.pm
>@@ -425,7 +425,7 @@ sub getframeworkinfo {
> 
> =head2 getitemtypeinfo
> 
>-  $itemtype = &getitemtype($itemtype, [$interface]);
>+  $itemtype = &getitemtypeinfo($itemtype, [$interface]);
> 
> Returns information about an itemtype. The optional $interface argument
> sets which interface ('opac' or 'intranet') to return the imageurl for.
>@@ -440,7 +440,7 @@ sub getitemtypeinfo {
>     $sth->execute($itemtype);
>     my $res = $sth->fetchrow_hashref;
> 
>-    $res->{imageurl} = getitemtypeimagelocation( ( $interface eq 'opac' ? 'opac' : 'intranet' ), $res->{imageurl} );
>+    $res->{imageurl} = getitemtypeimagelocation( ( ( defined $interface && $interface eq 'opac' ) ? 'opac' : 'intranet' ), $res->{imageurl} );
> 
>     return $res;
> }
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9174: 13791 | 13911 | 14347 | 14351 | 14937 | 14938 | 15022