Bugzilla – Attachment 143509 Details for
Bug 32028
Add page-section to various administration pages (part 2)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32028: (follow-up) Fix headings levels
Bug-32028-follow-up-Fix-headings-levels.patch (text/plain), 4.40 KB, created by
Martin Renvoize (ashimema)
on 2022-11-09 13:25:05 UTC
(
hide
)
Description:
Bug 32028: (follow-up) Fix headings levels
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-11-09 13:25:05 UTC
Size:
4.40 KB
patch
obsolete
>From 04baf05ec0c798874d12f56708bd5cb0fd3a3654 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 9 Nov 2022 13:23:39 +0000 >Subject: [PATCH] Bug 32028: (follow-up) Fix headings levels > >This patch corrects the headings levels on cash_registers, >patron-attr-types and restrictions admin pages. > >We also move the h2 headings inside the page-section div as appropriate. >--- > .../prog/en/modules/admin/cash_registers.tt | 22 +++++++++---------- > .../en/modules/admin/patron-attr-types.tt | 6 +++-- > .../prog/en/modules/admin/restrictions.tt | 2 +- > 3 files changed, 16 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt >index 4acc81a23e..f6ddab8b0d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt >@@ -159,14 +159,14 @@ Cash registers › Administration › Koha > </div> > > <h1>Cash registers</h1> >- <h3>Cash registers for <select id="branch_filter" name="branch_filter"> >- <option value=""></option> >- [% PROCESS options_for_libraries libraries => Branches.all( selected => branchcode, unfiltered => 1, ) %] >- </select> >- </h3> >- >- [% IF cash_registers.count %] > <div class="page-section"> >+ <h2>Cash registers for <select id="branch_filter" name="branch_filter"> >+ <option value=""></option> >+ [% PROCESS options_for_libraries libraries => Branches.all( selected => branchcode, unfiltered => 1, ) %] >+ </select> >+ </h2> >+ >+ [% IF cash_registers.count %] > <table id="table_cash_registers"> > <thead> > <th>Name</th> >@@ -205,10 +205,10 @@ Cash registers › Administration › Koha > [% END %] > </tbody> > </table> >- </div><!-- /.page-section --> >- [% ELSE %] >- <div class="dialog message">There are no cash registers defined. <a href="/cgi-bin/koha/admin/cash_registers.pl?op=add_form">Start adding cash registers</a>.</div> >- [% END # /cash_register.count %] >+ [% ELSE %] >+ <div class="dialog message">There are no cash registers defined. <a href="/cgi-bin/koha/admin/cash_registers.pl?op=add_form">Start adding cash registers</a>.</div> >+ [% END # /cash_register.count %] >+ </div> > [% END # /op == 'list' %] > </main> > </div> <!-- /.col-sm-10.col-sm-push-2 --> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt >index b35a242c11..3c26281a29 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt >@@ -292,10 +292,12 @@ Patron attribute types › Administration › Koha > [% END %] > [% IF ( available_attribute_types ) %] > [% FOREACH attribute IN available_attribute_types %] >+ <div class="page-section"> > [% IF attribute.class %] >- <h4>[% attribute.lib | html %]</h4> >+ <h2>[% attribute.lib | html %]</h2> >+ [% ELSE %] >+ <h2>Unclassified types</h2> > [% END %] >- <div class="page-section"> > <table class="patron_attributes_types" id="patron_attr[% attribute.class | html %]"> > <thead> > <tr> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt >index c298c725f5..6652fa0306 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt >@@ -160,7 +160,7 @@ > <a class="btn btn-default" id="newrestriction" href="/cgi-bin/koha/admin/restrictions.pl?op=add_form"><i class="fa fa-plus"></i> New restriction</a> > </div> > >- <h2>Patron restrictions</h2> >+ <h1>Patron restrictions</h1> > [% IF searchfield %] > You Searched for [% searchfield | html %]</span> > [% END %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32028
:
143052
|
143146
|
143214
|
143260
|
143261
|
143498
|
143499
|
143500
|
143503
|
143506
|
143507
|
143508
| 143509