Attachment 143523 Details for Bug 32139 – Bug 32139: Set "update on login" correctly when creating new IdP

[patch] Bug 32139: Set "update on login" correctly when creating new IdP

Bug-32139-Set-update-on-login-correctly-when-creat.patch (text/plain), 1.68 KB, created by Tomás Cohen Arazi (tcohen) on 2022-11-09 16:33:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-11-09 16:33:40 UTC

Size: 1.68 KB

patch

obsolete

>From 9d3a54f6f64941f27216158685b51a719982379c Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Wed, 9 Nov 2022 01:59:28 +0000
>Subject: [PATCH] Bug 32139: Set "update on login" correctly when creating new
> IdP
>
>This patches allows "Update on Login" to be set to "Yes" when
>creating a domain as part of a new Identity Provider.
>
>Test plan:
>1) Apply patch
>2) koha-plack --reload kohadev
>3) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl
>4) Click "New identity provider"
>5) Fill in "Code" and "Description" with "test"
>6) Click "Add default OAuth configuration"
>7) Click "Add default OAUth mapping"
>8) Fill in "Domain" with "*"
>9) Change "Allow OPAC", "Allow staff", "Auto register", and "Update on login"
>to "Yes"
>10) Click "Submit"
>11) Click "Manage Domains" for your new Identity Provider
>12) Note that "Allow opac", "Allow staff", "Auto register", and "Update on login"
>are all set to "Yes"
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> admin/identity_providers.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/identity_providers.pl b/admin/identity_providers.pl
>index 9a5f0cd786a..d663d828901 100755
>--- a/admin/identity_providers.pl
>+++ b/admin/identity_providers.pl
>@@ -67,7 +67,7 @@ if ( !$domain_ops && $op eq 'add' ) {
>     my $default_category_id = $input->param('default_category_id');
>     my $default_library_id  = $input->param('default_library_id');
>     my $domain              = $input->param('domain');
>-    my $update_on_auth      = $input->param('update_on_$update_on_auth');
>+    my $update_on_auth      = $input->param('update_on_auth');
> 
>     try {
>         Koha::Database->new->schema->txn_do(
>-- 
>2.38.1

Actions: View | Diff | Splinter Review

Attachments on bug 32139: 143454 | 143523