Bugzilla – Attachment 14372 Details for
Bug 7919
Display of values depending on the connexion library (authorised values, patron categories, extended attributes)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7919: FIX the "all" categories method
Bug-7919-FIX-the-all-categories-method.patch (text/plain), 1.91 KB, created by
Liz Rea
on 2013-01-02 21:02:15 UTC
(
hide
)
Description:
Bug 7919: FIX the "all" categories method
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2013-01-02 21:02:15 UTC
Size:
1.91 KB
patch
obsolete
>From 164c9ec9a4ce5c1ee906ac9f558fc5e5f035cb86 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 17 Dec 2012 11:04:07 +0100 >Subject: [PATCH] Bug 7919: FIX the "all" categories method > >The C4::Category->all method must return fields from the categories >table only. >Without this patch, there is 2 "categorycode" values, the second one is >sometimes undef (if no branch limitation). > >same for the GetBorrowercategoryList routine (some category codes are >undefined) > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Liz Rea <liz@catalyst.net.nz> >Signed off for also fixing problems with patron searching noted by Katrin. >--- > C4/Category.pm | 2 +- > C4/Members.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Category.pm b/C4/Category.pm >index fcb3ed8..255db2b 100644 >--- a/C4/Category.pm >+++ b/C4/Category.pm >@@ -79,7 +79,7 @@ sub all { > my $dbh = C4::Context->dbh; > # The categories table is small enough for > # `SELECT *` to be harmless. >- my $query = "SELECT * FROM categories"; >+ my $query = "SELECT categories.* FROM categories"; > $query .= qq{ > LEFT JOIN categories_branches ON categories_branches.categorycode = categories.categorycode > WHERE categories_branches.branchcode = ? OR categories_branches.branchcode IS NULL >diff --git a/C4/Members.pm b/C4/Members.pm >index 81b014b..90b3f73 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -1491,7 +1491,7 @@ sub GetBorrowercategoryList { > ? 0 > : C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; > my $dbh = C4::Context->dbh; >- my $query = "SELECT * FROM categories"; >+ my $query = "SELECT categories.* FROM categories"; > $query .= qq{ > LEFT JOIN categories_branches ON categories.categorycode = categories_branches.categorycode > WHERE branchcode = ? OR branchcode IS NULL GROUP BY description >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7919
:
8939
|
9170
|
9973
|
9984
|
10424
|
11163
|
11168
|
11373
|
11751
|
13736
|
13862
|
13867
|
13868
|
13891
|
13901
|
13952
|
13953
|
14162
|
14163
|
14184
|
14287
|
14350
|
14372
|
14377