Attachment 143771 Details for Bug 32162 – Bug 32162: Add primar key to erm_eholdings_packages_agreements

[patch] Bug 32162: Add primar key to erm_eholdings_packages_agreements

Bug-32162-Add-primar-key-to-ermeholdingspackagesag.patch (text/plain), 3.38 KB, created by Martin Renvoize (ashimema) on 2022-11-11 11:10:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-11-11 11:10:22 UTC

Size: 3.38 KB

patch

obsolete

>From 116ee8e7be4cec23b5aba7b8c5f5997e36c3ef08 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 10 Nov 2022 08:06:28 +0100
>Subject: [PATCH] Bug 32162: Add primar key to
> erm_eholdings_packages_agreements
>
>Test plan:
>Confirm that this change fixes the related TestBuilder.t failure
>Confirm that it does not break the eRM app, try to attach an agreement
>to a package.
>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../data/mysql/atomicupdate/bug_32162.pl      | 24 +++++++++++++++++++
> installer/data/mysql/kohastructure.sql        |  4 ++--
> 2 files changed, 26 insertions(+), 2 deletions(-)
> create mode 100755 installer/data/mysql/atomicupdate/bug_32162.pl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_32162.pl b/installer/data/mysql/atomicupdate/bug_32162.pl
>new file mode 100755
>index 0000000000..acfecddd4e
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_32162.pl
>@@ -0,0 +1,24 @@
>+use Modern::Perl;
>+
>+return {
>+    bug_number => "31162",
>+    description => "Add primary key to erm_eholdings_packages_agreements",
>+    up => sub {
>+        my ($args) = @_;
>+        my ($dbh, $out) = @$args{qw(dbh out)};
>+        unless ( primary_key_exists('erm_eholdings_packages_agreements') ){
>+            $dbh->do(q{
>+                ALTER TABLE erm_eholdings_packages_agreements
>+                DROP FOREIGN KEY erm_eholdings_packages_agreements_ibfk_1,
>+                DROP FOREIGN KEY erm_eholdings_packages_agreements_ibfk_2,
>+                DROP CONSTRAINT erm_eholdings_packages_agreements_uniq,
>+                ADD PRIMARY KEY(`package_id`, `agreement_id`)
>+            });
>+            $dbh->do(q{
>+                ALTER TABLE erm_eholdings_packages_agreements
>+                ADD CONSTRAINT `erm_eholdings_packages_agreements_ibfk_1` FOREIGN KEY (`package_id`) REFERENCES `erm_eholdings_packages` (`package_id`) ON DELETE CASCADE ON UPDATE CASCADE,
>+                ADD CONSTRAINT `erm_eholdings_packages_agreements_ibfk_2` FOREIGN KEY (`agreement_id`) REFERENCES `erm_agreements` (`agreement_id`) ON DELETE CASCADE ON UPDATE CASCADE
>+            });
>+        }
>+    },
>+};
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 7015a95ff3..beb769937e 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -2990,9 +2990,9 @@ DROP TABLE IF EXISTS `erm_eholdings_packages_agreements`;
> CREATE TABLE `erm_eholdings_packages_agreements` (
>     `package_id` INT(11) NOT NULL COMMENT 'link to the package',
>     `agreement_id` INT(11) NOT NULL COMMENT 'link to the agreement',
>-    UNIQUE KEY `erm_eholdings_packages_agreements_uniq` (`package_id`, `agreement_id`),
>     CONSTRAINT `erm_eholdings_packages_agreements_ibfk_1` FOREIGN KEY (`package_id`) REFERENCES `erm_eholdings_packages` (`package_id`) ON DELETE CASCADE ON UPDATE CASCADE,
>-    CONSTRAINT `erm_eholdings_packages_agreements_ibfk_2` FOREIGN KEY (`agreement_id`) REFERENCES `erm_agreements` (`agreement_id`) ON DELETE CASCADE ON UPDATE CASCADE
>+    CONSTRAINT `erm_eholdings_packages_agreements_ibfk_2` FOREIGN KEY (`agreement_id`) REFERENCES `erm_agreements` (`agreement_id`) ON DELETE CASCADE ON UPDATE CASCADE,
>+    PRIMARY KEY(`package_id`, `agreement_id`)
> ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
> 
> --
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 32162: 143622 | 143645 | 143682 | 143771