Attachment 143776 Details for Bug 31447 – Bug 31447: Use holds pick up branch in "Please confirm checkout" message

[patch] Bug 31447: Use holds pick up branch in "Please confirm checkout" message

Bug-31447-Use-holds-pick-up-branch-in-Please-confi.patch (text/plain), 3.09 KB, created by David Nind on 2022-11-11 11:25:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-11-11 11:25:59 UTC

Size: 3.09 KB

patch

obsolete

>From b0e86cc909edf1b986830b5f486669b5cbe894fb Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Tue, 23 Aug 2022 13:48:39 +0300
>Subject: [PATCH] Bug 31447: Use holds pick up branch in "Please confirm
> checkout" message
>
>When one tries to check out item which has hold in it,
>"Please confirm checkout" message uses patrons home library
>instead of holds pick up library. It would be more logical
>to use latter here.
>
>To test:
>1. Find record with holds.
>2. For first priority hold, change it's pick up library to differ from patrons homebranch if needed.
>3. Check out records item for a different patron.
>=> Note that notice reads: "Item ... has been on hold for ... at [patrons homebranch] since ...".
>4. Apply this patch.
>5. Repeat steps 2 and 3.
>=> Notice should now read: "Item ... has been on hold for ... at [holds pick up branch] since ...".
>
>Sponsored-by: Koha-Suomi Oy
>
>Signed-off-by: Axelle Clarisse <axelle.clarisse@univ-amu.fr>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> C4/Circulation.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index aa858a855b..336ce9490a 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -1191,7 +1191,7 @@ sub CanBookBeIssued {
>                     $needsconfirmation{'ressurname'} = $patron->surname;
>                     $needsconfirmation{'rescardnumber'} = $patron->cardnumber;
>                     $needsconfirmation{'resborrowernumber'} = $patron->borrowernumber;
>-                    $needsconfirmation{'resbranchcode'} = $patron->branchcode;
>+                    $needsconfirmation{'resbranchcode'} = $res->{branchcode};
>                     $needsconfirmation{'resreservedate'} = $res->{reservedate};
>                     $needsconfirmation{'reserve_id'} = $res->{reserve_id};
>                 }
>@@ -1202,7 +1202,7 @@ sub CanBookBeIssued {
>                     $needsconfirmation{'ressurname'} = $patron->surname;
>                     $needsconfirmation{'rescardnumber'} = $patron->cardnumber;
>                     $needsconfirmation{'resborrowernumber'} = $patron->borrowernumber;
>-                    $needsconfirmation{'resbranchcode'} = $patron->branchcode;
>+                    $needsconfirmation{'resbranchcode'} = $res->{branchcode};
>                     $needsconfirmation{'resreservedate'} = $res->{reservedate};
>                     $needsconfirmation{'reserve_id'} = $res->{reserve_id};
>                 }
>@@ -1213,7 +1213,7 @@ sub CanBookBeIssued {
>                     $needsconfirmation{'ressurname'} = $patron->surname;
>                     $needsconfirmation{'rescardnumber'} = $patron->cardnumber;
>                     $needsconfirmation{'resborrowernumber'} = $patron->borrowernumber;
>-                    $needsconfirmation{'resbranchcode'} = $patron->branchcode;
>+                    $needsconfirmation{'resbranchcode'} = $res->{branchcode};
>                     $needsconfirmation{'resreservedate'} = $res->{reservedate};
>                     $needsconfirmation{'reserve_id'} = $res->{reserve_id};
>                 }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31447: 140000 | 140338 | 141292 | 143112 | 143349 | 143386 | 143776 | 143777 | 143813 | 143814 | 144241