Bugzilla – Attachment 143792 Details for
Bug 32181
ERM - Cannot filter by expired when adding an agreement to EBSCO's package
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's package
Bug-32181-ERM---Fix-filter-by-expired-when-adding-.patch (text/plain), 1.86 KB, created by
Jonathan Druart
on 2022-11-11 15:34:25 UTC
(
hide
)
Description:
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's package
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-11-11 15:34:25 UTC
Size:
1.86 KB
patch
obsolete
>From 4e3493d81c48be537ffd8729a1269094d13f6892 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 11 Nov 2022 16:31:40 +0100 >Subject: [PATCH] Bug 32181: ERM - Fix 'filter by expired' when adding an > agreement to EBSCO's package > >We shouldn't change the current route (which will lead to change the >view) when we are adding an agreement to a EBSCO's package > >Test plan: >Go to E-Resource management / eHoldings / EBSCO / Packages >Search for a package, select one >Click "Add new agreement" >Use the "Filter by expired" filter >=> Without this patch you are redirected to the package list view >=> With this patch applied the table is filtered as expected >--- > .../prog/js/vue/components/ERM/AgreementsList.vue | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >index bb4dc481ec2..7b4cc1d24c0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >@@ -113,11 +113,13 @@ export default { > this.$emit("close") > }, > filter_table: async function () { >- let new_route = build_url( >- "/cgi-bin/koha/erm/agreements", >- this.filters >- ) >- this.$router.push(new_route) >+ if (this.before_route_entered) { >+ let new_route = build_url( >+ "/cgi-bin/koha/erm/agreements", >+ this.filters >+ ) >+ this.$router.push(new_route) >+ } > if (this.filters.by_expired) { > if (!this.filters.max_expiration_date) > this.filters.max_expiration_date = new Date() >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32181
:
143792
|
143855