Bugzilla – Attachment 143812 Details for
Bug 20207
Anonymous suggestions show in OPAC even when OPACViewOthersSuggestions is set to 'Don't show'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20207: Don't show search options when no suggestions show
Bug-20207-Dont-show-search-options-when-no-suggest.patch (text/plain), 2.54 KB, created by
Katrin Fischer
on 2022-11-13 14:10:59 UTC
(
hide
)
Description:
Bug 20207: Don't show search options when no suggestions show
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-11-13 14:10:59 UTC
Size:
2.54 KB
patch
obsolete
>From 724bb384b2aed96d5f155591941781db2dbbc5a2 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 13 Nov 2022 14:06:42 +0000 >Subject: [PATCH] Bug 20207: Don't show search options when no suggestions show > >When you are not logged in and OPACViewOthersSuggestions is >deactivated, you don't see any suggestions. > >When we see no suggestions, we should also not show the option >to serach in suggestions. > >To test: >* as a logged in user and logged out, try various combinations of: > * OPACViewOthersSuggestions > * AnonSuggestions >* Verify display matches expectations (new button, shown suggestions, > search input) > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index e62f951682..76bcf0b4e0 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -311,7 +311,7 @@ > > [% IF ( deleted ) %]<div class="alert alert-info">The selected suggestions have been deleted.</div>[% END %] > >- [% IF suggestions.size > 0 OR title_filter %] >+ [% IF (Koha.Preference( 'OPACViewOthersSuggestions' ) || loggedinusername) && (suggestions.size > 0 OR title_filter) %] > [% SET can_delete_suggestion = 0 %] > <form action="/cgi-bin/koha/opac-suggestions.pl" class="form-inline" id="search_suggestions_form" method="get"> > <div class="form-row"> >@@ -321,7 +321,7 @@ > <div class="col-auto my-1"> > <input type="text" name="title_filter" id="title_filter" value="[% title_filter | html %]" size="30" class="form-control form-control-sm" /> > </div> >- [% IF Koha.Preference( 'OPACViewOthersSuggestions' ) == 1 %] >+ [% IF Koha.Preference( 'OPACViewOthersSuggestions' ) %] > [% IF loggedinusername %] > <div class="col-auto my-1"> > <label class="sr-only" for="suggested_by_anyone">Suggested by:</label> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20207
:
143789
|
143798
|
143800
|
143811
| 143812