Attachment 143819 Details for Bug 31908 – Bug 31908: Replace an exit by a safe_exit in Auth.pm L1314

[patch] Bug 31908: Replace an exit by a safe_exit in Auth.pm L1314

Bug-31908-Replace-an-exit-by-a-safeexit-in-Authpm-.patch (text/plain), 984 bytes, created by Marcel de Rooy on 2022-11-14 12:20:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-11-14 12:20:44 UTC

Size: 984 bytes

patch

obsolete

>From 22c8ffd2df6c1046e3424742499af1c0ff45ebbd Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 14 Nov 2022 11:09:43 +0000
>Subject: [PATCH] Bug 31908: Replace an exit by a safe_exit in Auth.pm L1314
>Content-Type: text/plain; charset=utf-8
>
>No change in user experience. But since we can mock safe_exit,
>we can enhance test results.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Auth.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index ac73f2d018..312e73fdc0 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -1311,7 +1311,7 @@ sub checkauth {
>             $uri->query_param_delete('password');
>             $uri->query_param_delete('koha_login_context');
>             print $query->redirect(-uri => $uri->as_string, -cookie => $cookie, -status=>'303 See other');
>-            exit;
>+            safe_exit;
>         }
> 
>         return ( $userid, $cookie, $sessionID, $flags );
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31908: 142361 | 143392 | 143491 | 143786 | 143819 | 143820 | 143821 | 143822 | 143884 | 143885 | 143886 | 143887 | 145092 | 145093 | 145250 | 145251 | 145252