Bugzilla – Attachment 143824 Details for
Bug 32094
Consistent classes for primary buttons: Serials
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32094: Consistent classes for primary buttons: Serials
Bug-32094-Consistent-classes-for-primary-buttons-S.patch (text/plain), 15.18 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-11-14 12:32:02 UTC
(
hide
)
Description:
Bug 32094: Consistent classes for primary buttons: Serials
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-11-14 12:32:02 UTC
Size:
15.18 KB
patch
obsolete
>From fc08868976d9f79cd01e58be88bedcc86a117941 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 3 Nov 2022 14:34:59 +0000 >Subject: [PATCH] Bug 32094: Consistent classes for primary buttons: Serials > >This patch makes changes the button markup in serials templates so that >all submit buttons and any buttons that should should be styled as >primary buttons have the Bootstrap class "btn btn-primary." > >To test, apply the patch and view serials pages to confirm that >everything looks correct. In most cases there are no visible >changes. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../intranet-tmpl/prog/en/includes/subscriptions-search.inc | 2 +- > .../intranet-tmpl/prog/en/modules/serials/acqui-search.tt | 2 +- > .../prog/en/modules/serials/checkexpiration.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt | 4 ++-- > .../prog/en/modules/serials/routing-preview.tt | 6 +++--- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt | 2 +- > .../prog/en/modules/serials/serials-collection.tt | 2 +- > .../intranet-tmpl/prog/en/modules/serials/serials-search.tt | 4 ++-- > .../prog/en/modules/serials/subscription-add.tt | 6 +++--- > .../prog/en/modules/serials/subscription-batchedit.tt | 2 +- > .../prog/en/modules/serials/subscription-bib-search.tt | 2 +- > .../prog/en/modules/serials/subscription-frequencies.tt | 2 +- > .../prog/en/modules/serials/subscription-history.tt | 2 +- > .../prog/en/modules/serials/subscription-numberpatterns.tt | 2 +- > .../prog/en/modules/serials/subscription-renew.tt | 2 +- > 15 files changed, 21 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc >index 7fdea9c9336..fd1222ea334 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc >@@ -44,7 +44,7 @@ > <input type="hidden" name="basketno" value="[% basketno | html %]" /> > [% END %] > <fieldset class="action"> >- <input type="submit" value="Search" /> >+ <input type="submit" class="btn btn-primary" value="Search" /> > </fieldset> > </div> > </fieldset> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search.tt >index 48d601e9a93..37ae608d428 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search.tt >@@ -11,7 +11,7 @@ > <form action="/cgi-bin/koha/serials/acqui-search-result.pl" method="post"> > <label for="text">Vendor name: </label> > <input id="text" type="text" size="25" name="supplier" autofocus="autofocus" /> >- <input type="submit" class="button" value="OK" /> >+ <input type="submit" class="btn btn-primary" value="OK" /> > </form> > > [% INCLUDE 'intranet-bottom.inc' popup_window=1 %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >index 4c45c6f0a4a..2bae1396232 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >@@ -72,7 +72,7 @@ > </li> > </ol> > </fieldset> >-<fieldset class="action"><input type="submit" value="Search" /></fieldset> >+<fieldset class="action"><input type="submit" class="btn btn-primary" value="Search" /></fieldset> > </form> > > [% IF ( subscriptions_loop ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >index e3dcb9bb51e..7278029f060 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >@@ -97,7 +97,7 @@ > </option> > [% END %] > </select> >- <input type="submit" value="OK" /> >+ <input type="submit" class="btn btn-primary" value="OK" /> > </fieldset> > </form> <!-- /#claims --> > >@@ -230,7 +230,7 @@ > </select> > <input type="hidden" name="op" value="send_alert" /> > <input type="hidden" name="supplierid" value="[% supplierid | html %]" /> >- <input type="submit" name="submit" class="button" value="Send notification" /> >+ <input type="submit" name="submit" class="btn btn-primary" value="Send notification" /> > </fieldset> > [% END %] > </form> <!-- /#claims_form --> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt >index ed7ee3719a1..d3cc0a89927 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt >@@ -54,9 +54,9 @@ > </fieldset> > > <fieldset class="action"> >- <input type="submit" name="ok" id="save_and_preview" class="button" value="Save and preview routing slip" /> >-<input type="submit" name="edit" class="button" value="Edit" /> >-<input type="submit" name="delete" class="button" value="Delete" /></fieldset> >+ <input type="submit" name="ok" id="save_and_preview" class="btn btn-primary" value="Save and preview routing slip" /> >+<input type="submit" name="edit" class="btn btn-primary" value="Edit" /> >+<input type="submit" name="delete" class="btn btn-primary" value="Delete" /></fieldset> > </form> > > </main> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt >index f6b30345344..3e611bcfe45 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt >@@ -114,7 +114,7 @@ > </ol> > > </fieldset> >-<fieldset class="action"><input type="submit" name="submit" value="Save" /></fieldset> >+<fieldset class="action"><input type="submit" name="submit" class="btn btn-primary" value="Save" /></fieldset> > </form> > > </main> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >index 549c82b6b99..dd4191bd69d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >@@ -156,7 +156,7 @@ > <div id="subscription-year-[% year.year | html %]" role="tabpanel" class="tab-pane"> > [% IF ( CAN_user_serials_receive_serials ) %] > <p> >- <div class="btn-group"><input type="submit" value="Edit serials" class="btn btn-default btn-sm" /></div> >+ <div class="btn-group"><input type="submit" value="Edit serials" class="btn btn-primary btn-sm" /></div> > [% UNLESS subscription.closed %] > <div class="btn-group"> > <input type="button" value="Generate next" data-subscriptionid="[% subscriptionidlist | html %]" class="btn btn-default btn-sm generatenext" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >index 2bb8074831f..dc43ca65445 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >@@ -301,7 +301,7 @@ > <input type="hidden" name="mana" value="1" /> > [% END %] > <fieldset class="action"> >- <input type="submit" value="Search" /> >+ <input type="submit" class="btn btn-primary" value="Search" /> > </fieldset> > </fieldset> <!-- /.rows --> > </form> >@@ -432,7 +432,7 @@ > </ol> > <input type="hidden" name="searched" value="1" /> > <fieldset class="action"> >- <input type="submit" value="Search" /> >+ <input type="submit" class="btn btn-primary" value="Search" /> > </fieldset> > > </fieldset> <!-- /.brief --> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >index 45354977f70..7896caf808b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >@@ -284,7 +284,7 @@ fieldset.rows table { clear: none; margin: 0; } > </ol> > </fieldset> > <fieldset class="action"> >- <button type="button" id="subscription_add_next" style="float:right;">Next <i class="fa fa-long-arrow-right"></i></button> >+ <button type="button" class="btn btn-primary" id="subscription_add_next" style="float:right;">Next <i class="fa fa-long-arrow-right"></i></button> > </fieldset> > </div> <!-- /.col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2 --> > </div> <!-- /.row#page_1 --> >@@ -556,8 +556,8 @@ fieldset.rows table { clear: none; margin: 0; } > <input type="hidden" id="unitsperissue" name="unitsperissue" value=""/> > <input type="hidden" id="issuesperunit" name="issuesperunit" value=""/> > <fieldset class="action"> >- <button type="button" id="subscription_add_previous" style="float:left"><i class="fa fa-long-arrow-left"></i> Previous</button> >- <input id="save-subscription" type="submit" value="Save subscription" style="float:right;" accesskey="w"/> >+ <button type="button" class="btn btn-default" id="subscription_add_previous" style="float:left"><i class="fa fa-long-arrow-left"></i> Previous</button> >+ <input id="save-subscription" class="btn btn-primary" type="submit" value="Save subscription" style="float:right;" accesskey="w"/> > </fieldset> > </div> > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt >index f8b63ee8985..ba122bddf21 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt >@@ -166,7 +166,7 @@ > </fieldset> > > <fieldset class="action"> >- <button type="submit" name="batchedit" value="1">Save</button> >+ <button type="submit" name="batchedit" class="btn btn-primary" value="1">Save</button> > <a class="cancel" href="[% referrer | url %]">Cancel</a> > </fieldset> > </form> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt >index 0da440777dc..b1557da4a55 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt >@@ -46,7 +46,7 @@ > </ol> > </fieldset> > <fieldset class="action"> >- <input type="submit" value="Search" /> >+ <input type="submit" class="btn btn-primary" value="Search" /> > </fieldset> > </form> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt >index 1e9b446e6c3..0272ef373e3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt >@@ -97,7 +97,7 @@ > </ol> > </fieldset> > <fieldset class="action"> >- <input type="submit" value="Save" /> >+ <input type="submit" class="btn btn-primary" value="Save" /> > <a href="/cgi-bin/koha/serials/subscription-frequencies.pl" class="cancel">Cancel</a> > </fieldset> > </form> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-history.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-history.tt >index 4ff0c7ee512..c7cafef83b7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-history.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-history.tt >@@ -72,7 +72,7 @@ > <td><textarea name="librariannote" cols="60" rows="5">[% librariannote | html %]</textarea></td> > </tr> > </table> >- <input type="submit" value="Save subscription history" /> >+ <input type="submit" class="btn btn-primary" value="Save subscription history" /> > </form> > </div> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >index 7442ba1dfad..3f94b03c3f4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >@@ -183,7 +183,7 @@ > </table> > </fieldset> > <fieldset class="action"> >- <button type="submit" class="btn btn-default">Save</button> >+ <button type="submit" class="btn btn-primary">Save</button> > <button type="reset" class="btn btn-default">Reset</button> > <a class="cancel" href="/cgi-bin/koha/serials/subscription-numberpatterns.pl">Cancel</a> > </fieldset> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >index 10f2901a18d..1ad3540a202 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >@@ -82,7 +82,7 @@ > [% END %] > </ol> > </fieldset> >-<fieldset class="action"><input type="submit" value="Submit" class="button" /></fieldset> >+<fieldset class="action"><input type="submit" class="btn btn-primary" value="Submit" /></fieldset> > </form> > [% END %] > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32094
:
143121
|
143733
| 143824