Bugzilla – Attachment 143840 Details for
Bug 32169
Add page-section to item list on top of batch item edit (tools)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32169: Add page-section and fieldsets to batch item modification
Bug-32169-Add-page-section-and-fieldsets-to-batch-.patch (text/plain), 4.56 KB, created by
Martin Renvoize (ashimema)
on 2022-11-14 15:35:23 UTC
(
hide
)
Description:
Bug 32169: Add page-section and fieldsets to batch item modification
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-11-14 15:35:23 UTC
Size:
4.56 KB
patch
obsolete
>From 02eda231e6a91ead8db1ee6e9a0fed86d41c68f6 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 14 Nov 2022 15:33:45 +0000 >Subject: [PATCH] Bug 32169: Add page-section and fieldsets to batch item > modification > >This patch extends some alert boxes to include the error details tables >and updates the html_helpers include to add a page-section around the >item results table >--- > .../prog/en/includes/html_helpers.inc | 8 ++-- > .../prog/en/modules/tools/batchMod-edit.tt | 45 +++++++++---------- > 2 files changed, 26 insertions(+), 27 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >index 237500bf7a..c7ac3823c1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >@@ -209,12 +209,12 @@ > [% END %] > > [% BLOCK items_table_batchmod %] >- >+<div class="page-section"> > [% IF display_columns_selection %][%# Needs js/pages/batchMod.js %] > [% IF checkboxes_edit OR checkboxes_delete %] >- <div id="toolbar"> >+ <fieldset class="action"> > <a id="selectallbutton" href="#"><i class="fa fa-check"></i> Select all</a> | <a id="clearallbutton" href="#"><i class="fa fa-remove"></i> Clear all</a> | <a id="clearonloanbutton" href="#">Clear on loan</a> >- </div> >+ </fieldset> > [% END %] > > <div id="cataloguing_additem_itemlist"> >@@ -339,5 +339,5 @@ > [% END # /FOREACH items %] > </tbody> > </table> <!-- /#itemst --> >- >+</div> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >index d1c789e3ab..e1dbacec60 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >@@ -75,7 +75,6 @@ > </div> > [% END %] > >- > [% IF ( barcode_not_unique ) %] > <div class="dialog alert"> > <strong>Error saving item</strong>: Barcode must be unique. >@@ -90,19 +89,19 @@ > [% IF ( notfoundbarcodes.size ) %] > <div class="dialog alert"> > <p>Warning, the following barcodes were not found:</p> >+ <br/> >+ <table style="margin:auto;"> >+ <thead> >+ <tr><th>Barcodes not found</th></tr> >+ </thead> >+ <tbody> >+ [% FOREACH notfoundbarcode IN notfoundbarcodes %] >+ <tr><td>[% notfoundbarcode |html %]</td></td> >+ [% END %] >+ </tbody> >+ </table> > </div> > >- <table style="margin:auto;"> >- <thead> >- <tr><th>Barcodes not found</th></tr> >- </thead> >- <tbody> >- [% FOREACH notfoundbarcode IN notfoundbarcodes %] >- <tr><td>[% notfoundbarcode |html %]</td></td> >- [% END %] >- </tbody> >- </table> >- > [% IF ( item_loop ) %] > [% UNLESS ( too_many_items_display ) %] > <h4>The following barcodes were found: </h4> >@@ -113,18 +112,18 @@ > [% IF ( notfounditemnumbers.size ) %] > <div class="dialog alert"> > <p>Warning, the following itemnumbers were not found:</p> >+ <br/> >+ <table style="margin:auto;"> >+ <thead> >+ <tr><th>Itemnumbers not found</th></tr> >+ </thead> >+ <tbody> >+ [% FOREACH notfounditemnumber IN notfounditemnumbers %] >+ <tr><td>[% notfounditemnumber |html %]</td></td> >+ [% END %] >+ </tbody> >+ </table> > </div> >- >- <table style="margin:auto;"> >- <thead> >- <tr><th>Itemnumbers not found</th></tr> >- </thead> >- <tbody> >- [% FOREACH notfounditemnumber IN notfounditemnumbers %] >- <tr><td>[% notfounditemnumber |html %]</td></td> >- [% END %] >- </tbody> >- </table> > [% IF ( item_loop ) %] > [% UNLESS ( too_many_items_display ) %] > <h4>The following itemnumbers were found: </h4> >-- >2.38.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32169
:
143840
|
143854