Bugzilla – Attachment 143874 Details for
Bug 32155
Course reserves - instructors display is misaligned on course information page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32155: Fix alignment of course details page
Bug-32155-Fix-alignment-of-course-details-page.patch (text/plain), 2.33 KB, created by
Lucas Gass (lukeg)
on 2022-11-14 21:09:26 UTC
(
hide
)
Description:
Bug 32155: Fix alignment of course details page
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2022-11-14 21:09:26 UTC
Size:
2.33 KB
patch
obsolete
>From 59fbee8804c7df8a5cd5fe36674b29e723e1b6a6 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 14 Nov 2022 21:07:21 +0000 >Subject: [PATCH] Bug 32155: Fix alignment of course details page > >This patch eliminates some unnessesary CSS and converts the course details div into a fieldset. > >To test: >1. Create or edit an existing course. >2. Search and add an instructor. >3. Note that the columns are misaligned: the name of the course instructor is shown first, then the label "Instructors" is shown next. >4. Add another three instructors. >5. Note that this pushes the labels for the next few fields to the right. >6. Apply patch >7. Try steps 1-4 again and confirm everthing looks and works correctly. >--- > .../prog/en/modules/course_reserves/course-details.tt | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt >index 0ca98ead0a4..36abc1d1963 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt >@@ -11,12 +11,6 @@ > [% INCLUDE 'doc-head-close.inc' %] > [% FILTER collapse %] > <style> >- #instructors { >- float: left; >- } >- .instructor_line { >- padding: 0 .1em; >- } > .biblio-level-info { > background-color: #f3f3f3; > border-radius:5px; >@@ -81,7 +75,7 @@ > > <div class="page-section"> > >- <div class="rows"> >+ <fieldset class="rows"> > <ol> > <li><span class="label">Course name</span> [% course.course_name | html %]</li> > <li><span class="label">[% tp('Semester', 'Term') | html %]</span> [% AuthorisedValues.GetByCode( 'TERM', course.term ) | html %]</li> >@@ -103,7 +97,7 @@ > <li><span class="label">Student count</span> [% course.students_count | html %]</li> > <li><span class="label">Status</span> [% IF course.enabled == 'yes' %]Active[% ELSE %]Inactive[% END %]</li> > </ol> >- </div> >+ </fieldset> > </div> <!-- /.page-section --> > > [% IF course_reserves %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32155
:
143587
|
143874
|
143879
|
143913