Bugzilla – Attachment 143886 Details for
Bug 31908
New login fails while having cookie from previous session
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31908: Resolve second login with another userid
Bug-31908-Resolve-second-login-with-another-userid.patch (text/plain), 1.25 KB, created by
David Cook
on 2022-11-14 23:22:52 UTC
(
hide
)
Description:
Bug 31908: Resolve second login with another userid
Filename:
MIME Type:
Creator:
David Cook
Created:
2022-11-14 23:22:52 UTC
Size:
1.25 KB
patch
obsolete
>From e2a3d8c09fc8b28035413626787edda454048122 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 8 Nov 2022 13:40:17 +0000 >Subject: [PATCH] Bug 31908: Resolve second login with another userid > >Somewhere the line undef $userid got removed. >We need it to resolve the second login situation. > >Test plan: >Login in staff with user missing privileges. >On the login form login again with another staff user. >Note that you do no longer crash. > >Run t/db../Auth.t >Run t/db../Koha/Auth/TwoFactorAuth.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> > >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > C4/Auth.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 312e73fdc0..c135521f2d 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -906,6 +906,7 @@ sub checkauth { > $cookie = $cookie_mgr->clear_unless( $query->cookie, @$cookie ); > C4::Context::_unset_userenv($sessionID); > $sessionID = undef; >+ undef $userid; # IMPORTANT: this assures us a new session in code below > } elsif (!$logout) { > > $cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie( >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31908
:
142361
|
143392
|
143491
|
143786
|
143819
|
143820
|
143821
|
143822
|
143884
|
143885
| 143886 |
143887
|
145092
|
145093
|
145250
|
145251
|
145252