Attachment 143889 Details for Bug 32205 – Bug 32205: Remove unnecessary syspref template params for failed OPAC auth

[patch] Bug 32205: Remove unnecessary syspref template params for failed OPAC auth

Bug-32205-Remove-unnecessary-syspref-template-para.patch (text/plain), 2.15 KB, created by David Cook on 2022-11-15 01:28:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2022-11-15 01:28:34 UTC

Size: 2.15 KB

patch

obsolete

>From c4e68fcc3f4421c0ed6af19f3a7f3988f20110ac Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Tue, 15 Nov 2022 01:25:42 +0000
>Subject: [PATCH] Bug 32205: Remove unnecessary syspref template params for
> failed OPAC auth
>
>This patch removes some unnecessary syspref template params for
>failed OPAC auth. The templates handle these syspref using the
>Koha.Preference() TT plugin function, so they're completely redundant
>and just make checkauth() longer than it needs to be.
>
>Test plan:
>1) Apply patch
>2) Enable OpacCloud, OpacBrowser, and OpacTopissue sysprefs
>3) koha-plack --restart kohadev
>4) Log out of Koha if you're logged in
>5) Go to http://localhost:8080/cgi-bin/koha/opac-user.pl
>6) Note that you can see the Cart as well as links for the following:
>Browse by hierarchy, Authority search, Tag cloud, Subject cloud,
>Most popular
>---
> C4/Auth.pm | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index ac73f2d018..8534252226 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -1356,12 +1356,6 @@ sub checkauth {
>         opacreadinghistory                    => C4::Context->preference("opacreadinghistory"),
>         opaclanguagesdisplay                  => C4::Context->preference("opaclanguagesdisplay"),
>         OPACUserJS                            => C4::Context->preference("OPACUserJS"),
>-        opacbookbag                           => "" . C4::Context->preference("opacbookbag"),
>-        OpacCloud                             => C4::Context->preference("OpacCloud"),
>-        OpacTopissue                          => C4::Context->preference("OpacTopissue"),
>-        OpacAuthorities                       => C4::Context->preference("OpacAuthorities"),
>-        OpacBrowser                           => C4::Context->preference("OpacBrowser"),
>-        TagsEnabled                           => C4::Context->preference("TagsEnabled"),
>         OPACUserCSS                           => C4::Context->preference("OPACUserCSS"),
>         intranetcolorstylesheet               => C4::Context->preference("intranetcolorstylesheet"),
>         intranetstylesheet                    => C4::Context->preference("intranetstylesheet"),
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32205: 143889 | 144827 | 146446 | 147201