Attachment 143901 Details for Bug 32171 – Bug 32171: Store after populating order

[patch] Bug 32171: Store after populating order

Bug-32171-Store-after-populating-order.patch (text/plain), 1.33 KB, created by Nick Clemens (kidclamp) on 2022-11-15 12:58:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-11-15 12:58:39 UTC

Size: 1.33 KB

patch

obsolete

>From 12b8fea57483ba272097e84ec46fc1e2547464a6 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 10 Nov 2022 20:23:17 +0000
>Subject: [PATCH] Bug 32171: Store after populating order
>
>This updates the call to store after populating the order
>
>I put this on it's own bug just for sake of dependency, in case it is needed
>seperate from 32166 for backports
>
>To test:
>1 - Apply and test with bug 32166
>---
> acqui/addorderiso2709.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl
>index e6d50ab454..6907fa6ade 100755
>--- a/acqui/addorderiso2709.pl
>+++ b/acqui/addorderiso2709.pl
>@@ -291,9 +291,10 @@ if ($op eq ""){
>                     # remove uncertainprice flag if we have found a price in the MARC record
>                     $orderinfo{uncertainprice} = 0 if $orderinfo{listprice};
> 
>-                    my $order = Koha::Acquisition::Order->new( \%orderinfo )->store;
>+                    my $order = Koha::Acquisition::Order->new( \%orderinfo );
>                     $order->populate_with_prices_for_ordering();
>                     $order->populate_with_prices_for_receiving();
>+                    $order->store;
>                     $order->add_item( $_ ) for @{ $budget_hash->{$budget_id}->{itemnumbers} };
>                 }
>             }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32171: 143707 | 143901 | 143919 | 143954