Attachment 143918 Details for Bug 30694 – Bug 30694: Set decreaseloanholds undef when deleting circulation rule

[patch] Bug 30694: Set decreaseloanholds undef when deleting circulation rule

Bug-30694-Set-decreaseloanholds-undef-when-deletin.patch (text/plain), 1.70 KB, created by Katrin Fischer on 2022-11-15 16:29:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-11-15 16:29:50 UTC

Size: 1.70 KB

patch

obsolete

>From d9a16367fc881b26b0da4f71241faa9bb09c8253 Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Tue, 15 Nov 2022 09:31:13 +0200
>Subject: [PATCH] Bug 30694: Set decreaseloanholds undef when deleting
> circulation rule
>
>When one tries to delete rule with field "Decreased loan period
>for high holds" filled, delete fails without errors. This happens
>because rule isn't set in code section handling the delete in
>smart-rules.pl.
>
>To test:
>1. Create a new circulation rule and fill all fields.
>2. Try to delete the rule.
>=> Rule isn't deleted, all fields except "Decreased loan period
>for high holds" are now empty or have value "Unlimited".
>3. Modify the rule and set field "Decreased loan period for high
>holds" empty.
>4. Delete the rule.
>=> Rule is deleted successfully.
>5. Create a new rule, fill all fields expect field "Decreased loan
>period for high holds".
>6. Delete the rule.
>=> Rule is deleted successfully.
>7. Apply this patch.
>8. Again create a new rule with field "Decreased loan period for high holds" filled.
>9. Try to delete the rule.
>=> Rule is deleted successfully.
>
>Sponsored-by: Koha-Suomi Oy
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> admin/smart-rules.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl
>index b71179437f..5650bc8529 100755
>--- a/admin/smart-rules.pl
>+++ b/admin/smart-rules.pl
>@@ -114,6 +114,7 @@ if ($op eq 'delete') {
>                 recall_due_date_interval         => undef,
>                 recall_overdue_fine              => undef,
>                 recall_shelf_time                => undef,
>+                decreaseloanholds                => undef,
>             }
>         }
>     );
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30694: 143891 | 143918 | 144685