Attachment 143936 Details for Bug 16223 – Bug 16223: Add correct value attributes to restriction options in select element

[patch] Bug 16223: Add correct value attributes to restriction options in select element

0001-Bug-16223-Add-correct-value-attributes-to.patch (text/plain), 2.27 KB, created by Emmi Takkinen on 2022-11-16 07:30:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmi Takkinen

Created: 2022-11-16 07:30:32 UTC

Size: 2.27 KB

patch

obsolete

>From 8aae962d58f10e0d30923052b24dc1b574ec560b Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Wed, 16 Nov 2022 09:26:46 +0200
>Subject: [PATCH] Bug 16223: Add correct value attributes to restriction
> options in select element
>
>Restrictions weren't lift after payment because value
>attributes for restrictions code were missing from
>restriction select element in patron-restrictions-tab.inc.
>Due this restrictions were always set as type "MANUAL".
>
>To test:
>1. Add new restriction which has "Lift after payment?" set
>as Yes and fee limit as 5.
>2. Create fees for a patron so they exceed fee limit e.g. 10
>3. Add restriction made in step 1. for the patron
>4. Pay patrons fees partially so that they go under fee limit
>=> Note that patrons restriction should now be lifted.
>
>Also prove t/db_dependent/Patron/Borrower_Debarments.t.
>
>Sponsored-by: Koha-Suomi Oy
>---
> .../prog/en/includes/patron-restrictions-tab.inc              | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc
>index 4bedce39d1..1242dbf746 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc
>@@ -59,9 +59,9 @@
>                             [% FOREACH restriction_type IN restriction_types %]
>                                 [% IF !restriction_type.is_system %]
>                                    [% IF restriction_type.is_default %]
>-                                   <option value="[% code | html %]" selected>[% PROCESS restriction_type_description %]</option>
>+                                   <option value="[% restriction_type.code | html %]" selected>[% PROCESS restriction_type_description %]</option>
>                                    [% ELSE %]
>-                                   <option value="[% code | html %]">[% PROCESS restriction_type_description %]</option>
>+                                   <option value="[% restriction_type.code | html %]">[% PROCESS restriction_type_description %]</option>
>                                    [% END %]
>                                 [% END %]
>                             [% END %]
>-- 
>2.34.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 16223: 50078 | 50084 | 99697 | 99698 | 104399 | 104400 | 114272 | 114273 | 118526 | 118572 | 118574 | 118575 | 122768 | 122769 | 127252 | 128005 | 132284 | 132285 | 132286 | 132287 | 143388 | 143389 | 143390 | 143462 | 143670 | 143671 | 143672 | 143688 | 143689 | 143690 | 143765 | 143766 | 143767 | 143768 | 143769 | 143770 | 143936 | 146051 | 146052 | 146053 | 146054 | 146055 | 146056 | 146057 | 148307 | 148308 | 148309 | 148310 | 148311 | 148312 | 148313 | 150024 | 150025 | 150026 | 150027 | 150028 | 150029 | 153024 | 153025 | 153026 | 153027 | 153028 | 153029 | 155644 | 155645 | 155646 | 155647 | 155648 | 155649 | 155650 | 156841 | 156842 | 156843 | 156844 | 156845 | 156846 | 156847 | 156848 | 156849 | 156850