Attachment 14403 Details for Bug 9211 – Bug 9211 follow-up fixing 2 tiny mistakes in unit test

[patch] Bug 9211 follow-up fixing 2 tiny mistakes in unit test

Bug-9211-follow-up-fixing-2-tiny-mistakes-in-unit-.patch (text/plain), 1.21 KB, created by Paul Poulain on 2013-01-03 16:54:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Poulain

Created: 2013-01-03 16:54:56 UTC

Size: 1.21 KB

patch

obsolete

>From 169e10aca12b5fff957564b79907fbd0a5bd0dfd Mon Sep 17 00:00:00 2001
>From: Paul Poulain <paul.poulain@biblibre.com>
>Date: Thu, 3 Jan 2013 17:51:06 +0100
>Subject: [PATCH] Bug 9211 follow-up fixing 2 tiny mistakes in unit test
>
> * the new test was not announced (26 announced, 27 run)
> * $daycount already declared, resulting in
>"my" variable $daycount masks earlier declaration in same scope at t/Calendar.t line 93.
>
>with this patch prove t/Calendar.t is green ;-)
>---
> t/Calendar.t |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/Calendar.t b/t/Calendar.t
>index 3b86851..1a7d318 100755
>--- a/t/Calendar.t
>+++ b/t/Calendar.t
>@@ -4,7 +4,7 @@ use strict;
> use warnings;
> use DateTime;
> use DateTime::Duration;
>-use Test::More tests => 26;
>+use Test::More tests => 27;
> use Koha::DateUtils;
> 
> BEGIN {
>@@ -90,7 +90,7 @@ my $daycount = $cal->days_between( $test_dt, $later_dt );
> cmp_ok( $daycount->in_units('days'),
>     '==', 48, 'days_between calculates correctly' );
> 
>-my $daycount = $cal->days_between( $later_dt, $test_dt );
>+$daycount = $cal->days_between( $later_dt, $test_dt );
> cmp_ok( $daycount->in_units('days'),
>     '==', 48, 'days_between calculates correctly with dates reversed' );
> 
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9211: 13886 | 13945 | 13946 | 14400 | 14401 | 14402 | 14403