Attachment 144030 Details for Bug 32241 – Bug 32241: Add page-section to list of records in batch record modificaton (tool)

[patch] Bug 32241: Add page-section to list of records in batch record modificaton (tool)

Bug-32241-Add-page-section-to-list-of-records-in-b.patch (text/plain), 9.76 KB, created by Owen Leonard on 2022-11-17 19:16:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2022-11-17 19:16:54 UTC

Size: 9.76 KB

patch

obsolete

>From 8c1673a7c6eba995ceb1e9fa6430790141c87287 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 17 Nov 2022 19:13:33 +0000
>Subject: [PATCH] Bug 32241: Add page-section to list of records in batch
> record modificaton (tool)
>
>This patch modifies the batch record modification page template so that
>the preview of submitted records is contained in a .page-section
>container.
>
>To test, apply the patch and go to Cataloging -> Batch record
>modification.
>
>Submit a batch of bibliographic record numbers and a batch of authority
>record numbers. In both cases the page which previews the list of
>submitted records in a table should be correctly styled.
>---
> .../tools/batch_record_modification.tt        | 80 ++++++++++---------
> 1 file changed, 42 insertions(+), 38 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>index aaf1ab9f66..7e166637e9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>@@ -201,54 +201,58 @@
>                                         <a id="selectall" href="#"><i class="fa fa-check"></i> Select all</a>
>                                         | <a id="clearall" href="#"><i class="fa fa-remove"></i> Clear all</a>
>                                     </div>
>-                                    <table id="biblios" class="records">
>-                                        <thead>
>-                                            <tr>
>-                                                <th>&nbsp;</th>
>-                                                <th>Biblionumber</th>
>-                                                <th>Title</th>
>-                                                <th>&nbsp;</th>
>-                                            </tr>
>-                                        </thead>
>-                                        <tbody>
>-                                            [% FOR biblio IN records %]
>+                                    <div class="page-section">
>+                                        <table id="biblios" class="records">
>+                                            <thead>
>                                                 <tr>
>-                                                    <td><input type="checkbox" name="record_id" value="[% biblio.biblionumber | html %]" /></td>
>-                                                    <td>[% biblio.biblionumber | html %]</td>
>-                                                    <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblio.biblionumber | uri %]">[% biblio.title | html %]</a></td>
>-                                                    <td class="actions">
>-                                                        <a href="/cgi-bin/koha/svc/records/preview?record_type=biblio&record_id=[% biblio.biblionumber | uri %]&mmtid=[% mmtid | uri %]&overlay_context=batchmod" class="previewMARC btn btn-default btn-xs" data-record_type="biblio" data-record_id="[% biblio.biblionumber | html %]" data-mmtid="[% mmtid | html %]" title="Preview MARC"><i class="fa fa-eye"></i> Show MARC</a>
>-                                                    </td>
>+                                                    <th>&nbsp;</th>
>+                                                    <th>Biblionumber</th>
>+                                                    <th>Title</th>
>+                                                    <th>&nbsp;</th>
>                                                 </tr>
>-                                            [% END %]
>-                                        </tbody>
>-                                    </table> 
>+                                            </thead>
>+                                            <tbody>
>+                                                [% FOR biblio IN records %]
>+                                                    <tr>
>+                                                        <td><input type="checkbox" name="record_id" value="[% biblio.biblionumber | html %]" /></td>
>+                                                        <td>[% biblio.biblionumber | html %]</td>
>+                                                        <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblio.biblionumber | uri %]">[% biblio.title | html %]</a></td>
>+                                                        <td class="actions">
>+                                                            <a href="/cgi-bin/koha/svc/records/preview?record_type=biblio&record_id=[% biblio.biblionumber | uri %]&mmtid=[% mmtid | uri %]&overlay_context=batchmod" class="previewMARC btn btn-default btn-xs" data-record_type="biblio" data-record_id="[% biblio.biblionumber | html %]" data-mmtid="[% mmtid | html %]" title="Preview MARC"><i class="fa fa-eye"></i> Show MARC</a>
>+                                                        </td>
>+                                                    </tr>
>+                                                [% END %]
>+                                            </tbody>
>+                                        </table> 
>+                                    </div>
>                                     <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will modify all selected biblios!</div>
>                                 [% ELSE %]
>                                     <div class="btn-toolbar selections-toolbar">
>                                         <a id="selectall" href="#"><i class="fa fa-check"></i> Select all</a>
>                                         | <a id="clearall" href="#"><i class="fa fa-remove"></i> Clear all</a>
>                                     </div>
>-                                    <table id="authorities" class="records">
>-                                        <thead>
>-                                            <tr>
>-                                                <th></th>
>-                                                <th>AuthID</th>
>-                                                <th>Summary</th>
>-                                                <th>&nbsp;</th>
>-                                            </tr>
>-                                        </thead>
>-                                        <tbody>
>-                                            [% FOR authority IN records %]
>+                                    <div class="page-section">
>+                                        <table id="authorities" class="records">
>+                                            <thead>
>                                                 <tr>
>-                                                    <td><input type="checkbox" name="record_id" value="[% authority.authid | html %]" data-usage="[% authority.count_usage | html %]" /></td>
>-                                                    <td><a href="/cgi-bin/koha/authorities/detail.pl?authid=[% authority.authid | uri %]">[% authority.authid | html %]</a></td>
>-                                                    <td>[% PROCESS authresult summary=authority.summary authid=authority.authid %]</td>
>-                                                    <td class="actions"><a href="/cgi-bin/koha/svc/records/preview?record_type=authority&record_id=[% authority.authid | uri %]&mmtid=[% mmtid | uri %]&overlay_context=batchmod" data-record_type="authority" data-record_id="[% authority.authid | html %]" data-mmtid="[% mmtid | html %]" class="previewMARC btn btn-default btn-xs"><i class='fa fa-eye'></i> Show MARC</a>
>+                                                    <th></th>
>+                                                    <th>AuthID</th>
>+                                                    <th>Summary</th>
>+                                                    <th>&nbsp;</th>
>                                                 </tr>
>-                                            [% END %]
>-                                        </tbody>
>-                                    </table> 
>+                                            </thead>
>+                                            <tbody>
>+                                                [% FOR authority IN records %]
>+                                                    <tr>
>+                                                        <td><input type="checkbox" name="record_id" value="[% authority.authid | html %]" data-usage="[% authority.count_usage | html %]" /></td>
>+                                                        <td><a href="/cgi-bin/koha/authorities/detail.pl?authid=[% authority.authid | uri %]">[% authority.authid | html %]</a></td>
>+                                                        <td>[% PROCESS authresult summary=authority.summary authid=authority.authid %]</td>
>+                                                        <td class="actions"><a href="/cgi-bin/koha/svc/records/preview?record_type=authority&record_id=[% authority.authid | uri %]&mmtid=[% mmtid | uri %]&overlay_context=batchmod" data-record_type="authority" data-record_id="[% authority.authid | html %]" data-mmtid="[% mmtid | html %]" class="previewMARC btn btn-default btn-xs"><i class='fa fa-eye'></i> Show MARC</a>
>+                                                    </tr>
>+                                                [% END %]
>+                                            </tbody>
>+                                        </table> 
>+                                    </div>
>                                     <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will modify all selected authorities!</div>
>                                 [% END %]
>                                 <fieldset class="action">
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 32241: 144030 | 144039