Attachment 144051 Details for Bug 32045 – Bug 32045: Use bootstrap tabs to select item tab

[patch] Bug 32045: Use bootstrap tabs to select item tab

Bug-32045-Use-bootstrap-tabs-to-select-item-tab.patch (text/plain), 2.15 KB, created by Marcel de Rooy on 2022-11-18 10:00:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-11-18 10:00:48 UTC

Size: 2.15 KB

patch

obsolete

>From e7a5c8a62aad0bd731dda0fca5f70b5f41aa9ef8 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 15 Nov 2022 14:13:53 +0000
>Subject: [PATCH] Bug 32045: Use bootstrap tabs to select item tab
>Content-Type: text/plain; charset=utf-8
>
>When the form to add orders from a staged file is validated, we use
>toptabs functionality to switch to the item tab if there are missing fields.
>
>The display now uses bootstrap tabs, so the JS is throwing an error:
>Uncaught Error: cannot call methods on tabs prior to initialization; attempted to call method 'option'
>
>This patch simply switches the call to switch tabs
>
>To test:
>1 - Stage a file for import
>2 - Either use Marc(Item)FieldsToOrder to populate the orders
>    or select a budget on the third tab
>3 - View the second tab, items info, confirm itemtype is required, but don't populate it
>4 - Attempt to save order, nothing happens
>5 - Check the JS console (F12)
>6 - Note the error:
>    Uncaught Error: cannot call methods on tabs prior to initialization; attempted to call method 'option'
>7 - Apply patch
>8 - Cancel and add from staged file again
>9 - Select a budget and save
>10 - You now get an error popup: Some required item subfields are not set
>11 - Confirm after the error you are shown the items tab
>12 - Select itemtype
>13 - Save
>14 - Confirm orders added successfully
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js b/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
>index 34785cda2c..8b960108a1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
>@@ -73,7 +73,7 @@ $(document).ready(function() {
> 
>         if (0 < CheckMandatorySubfields(this.form)) {
>             // Open the item tab
>-            $('#tabs').tabs('option', 'active', 1);
>+            $('.nav-tabs .items_info').tab('show');
> 
>             alert(__('Some required item subfields are not set'));
>             return false;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32045: 143905 | 143909 | 144051