Bugzilla – Attachment 144071 Details for
Bug 31378
Add a generic OAuth2/OIDC client implementation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31378: (QA follow-up) Defer store until JSON fields are populated
Bug-31378-QA-follow-up-Defer-store-until-JSON-fiel.patch (text/plain), 2.69 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-11-18 15:30:49 UTC
(
hide
)
Description:
Bug 31378: (QA follow-up) Defer store until JSON fields are populated
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-11-18 15:30:49 UTC
Size:
2.69 KB
patch
obsolete
>From afd0bf0678efe2726930ee271403ef43246eda5e Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 18 Nov 2022 12:29:55 -0300 >Subject: [PATCH] Bug 31378: (QA follow-up) Defer store until JSON fields are > populated > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Auth/Identity/Provider.pm | 4 ++-- > Koha/REST/V1/Auth/Identity/Providers.pm | 16 ++++++++-------- > 2 files changed, 10 insertions(+), 10 deletions(-) > >diff --git a/Koha/Auth/Identity/Provider.pm b/Koha/Auth/Identity/Provider.pm >index 4d29b812707..e9dfc2fddbb 100644 >--- a/Koha/Auth/Identity/Provider.pm >+++ b/Koha/Auth/Identity/Provider.pm >@@ -107,7 +107,7 @@ sub set_config { > > try { > my $encoded_config = encode_json($config); >- $self->config($encoded_config)->store; >+ $self->config($encoded_config); > } catch { > Koha::Exceptions::Object::BadValue->throw("Error serializing data into JSON: $_"); > }; >@@ -147,7 +147,7 @@ sub set_mapping { > > try { > my $encoded_mapping = encode_json( $mapping ); >- $self->mapping( $encoded_mapping )->store; >+ $self->mapping( $encoded_mapping ); > } > catch { > Koha::Exceptions::Object::BadValue->throw("Error serializing data into JSON: $_"); >diff --git a/Koha/REST/V1/Auth/Identity/Providers.pm b/Koha/REST/V1/Auth/Identity/Providers.pm >index 6862ae75704..2f3dede36a9 100644 >--- a/Koha/REST/V1/Auth/Identity/Providers.pm >+++ b/Koha/REST/V1/Auth/Identity/Providers.pm >@@ -108,11 +108,10 @@ sub add { > > my $class = Koha::Auth::Identity::Provider::protocol_to_class_mapping->{$protocol}; > >- my $provider = $class->new_from_api( $body ); >- $provider->store; >- >- $provider->set_config( $config ); >- $provider->set_mapping( $mapping ); >+ my $provider = $class->new_from_api( $body ) >+ ->set_config( $config ) >+ ->set_mapping( $mapping ) >+ ->store; > > $c->res->headers->location( $c->req->url->to_string . '/' . $provider->identity_provider_id ); > return $c->render( >@@ -173,9 +172,10 @@ sub update { > > $provider = $provider->set_from_api( $body )->upgrade_class; > >- $provider->set_config( $config ); >- $provider->set_mapping( $mapping ); >- # set_config and set_mapping already called store() >+ $provider->set_config( $config ) >+ ->set_mapping( $mapping ) >+ ->store; >+ > $provider->discard_changes; > > return $c->render( >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31378
:
141362
|
141363
|
141364
|
141365
|
141366
|
141367
|
141368
|
141369
|
141370
|
141371
|
141372
|
141373
|
141374
|
141375
|
141376
|
141377
|
141378
|
141514
|
141771
|
141772
|
141773
|
141774
|
141775
|
141776
|
141777
|
141778
|
141779
|
141780
|
141781
|
141782
|
141783
|
141784
|
141785
|
141786
|
141787
|
141788
|
141801
|
141802
|
141803
|
141804
|
141805
|
141806
|
141807
|
141808
|
141809
|
141810
|
141811
|
141812
|
141813
|
141814
|
141815
|
141816
|
141817
|
141818
|
141853
|
143056
|
143087
|
143088
|
143089
|
143090
|
143091
|
143092
|
143093
|
143094
|
143095
|
143096
|
143097
|
143098
|
143099
|
143100
|
143101
|
143102
|
143103
|
143104
|
143105
|
143106
|
143107
|
143186
|
143187
|
143188
|
143189
|
143190
|
143191
|
143192
|
143193
|
143194
|
143195
|
143196
|
143197
|
143198
|
143199
|
143200
|
143202
|
143204
|
143205
|
143206
|
143207
|
143208
|
143215
|
143216
|
143217
|
143218
|
143219
|
143220
|
143221
|
143222
|
143223
|
143224
|
143225
|
143226
|
143227
|
143228
|
143229
|
143230
|
143231
|
143232
|
143233
|
143234
|
143235
|
143236
|
143266
|
143267
|
143268
|
143269
|
143270
|
143271
|
143272
|
143273
|
143274
|
143275
|
143277
|
143278
|
143279
|
143280
|
143281
|
143282
|
143283
|
143284
|
143285
|
143286
|
143287
|
143288
|
143396
|
143397
|
143398
|
143399
|
143400
|
143401
|
143402
|
143403
|
143404
|
143405
|
143406
|
143407
|
143408
|
143409
|
143410
|
143411
|
143412
|
143413
|
143414
|
143415
|
143416
|
143417
|
143418
|
143420
|
143421
|
143422
|
143423
|
143424
|
143425
|
143426
|
143427
|
143428
|
143429
|
143430
|
143431
|
143432
|
143433
|
143434
|
143435
|
143436
|
143437
|
143438
|
143439
|
143440
|
143441
|
143442
|
143443
|
143450
| 144071 |
144175