Bugzilla – Attachment 14416 Details for
Bug 8433
use English not needed in modules not using English
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8433 Remove unused 'use English'
Bug-8433-Remove-unused-use-English.patch (text/plain), 2.44 KB, created by
Jonathan Druart
on 2013-01-04 13:57:56 UTC
(
hide
)
Description:
Bug 8433 Remove unused 'use English'
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-01-04 13:57:56 UTC
Size:
2.44 KB
patch
obsolete
>From 231ff7a45e7f97560c3fb07e8a26954805127e0b Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 12 Jul 2012 17:11:14 +0100 >Subject: [PATCH] Bug 8433 Remove unused 'use English' > >Adding a use English to mosules which dont may >waste a few CPU cycles and bytes of storage >but doesnt add anything to the sum of human happiness > >Remove unnecessary use English's >Removed already commented out but equally unnrcessary >use Exporter in same modules > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > C4/SIP/Sip.pm | 1 - > C4/SIP/Sip/Configuration.pm | 1 - > C4/SIP/Sip/Configuration/Account.pm | 2 -- > C4/SIP/Sip/Configuration/Institution.pm | 2 -- > C4/SIP/Sip/Configuration/Service.pm | 2 -- > 5 files changed, 8 deletions(-) > >diff --git a/C4/SIP/Sip.pm b/C4/SIP/Sip.pm >index 8807df6..7a3d257 100644 >--- a/C4/SIP/Sip.pm >+++ b/C4/SIP/Sip.pm >@@ -6,7 +6,6 @@ package Sip; > > use strict; > use warnings; >-use English; > use Exporter; > use Readonly; > >diff --git a/C4/SIP/Sip/Configuration.pm b/C4/SIP/Sip/Configuration.pm >index 662e24c..9a281dd 100644 >--- a/C4/SIP/Sip/Configuration.pm >+++ b/C4/SIP/Sip/Configuration.pm >@@ -7,7 +7,6 @@ > package Sip::Configuration; > > use strict; >-use English; > use warnings; > use XML::Simple qw(:strict); > >diff --git a/C4/SIP/Sip/Configuration/Account.pm b/C4/SIP/Sip/Configuration/Account.pm >index 7b3d03e..1867a4c 100644 >--- a/C4/SIP/Sip/Configuration/Account.pm >+++ b/C4/SIP/Sip/Configuration/Account.pm >@@ -7,8 +7,6 @@ package Sip::Configuration::Account; > > use strict; > use warnings; >-use English; >-# use Exporter; > > sub new { > my ($class, $obj) = @_; >diff --git a/C4/SIP/Sip/Configuration/Institution.pm b/C4/SIP/Sip/Configuration/Institution.pm >index 1e50af2..cd2c80c 100644 >--- a/C4/SIP/Sip/Configuration/Institution.pm >+++ b/C4/SIP/Sip/Configuration/Institution.pm >@@ -7,8 +7,6 @@ package Sip::Configuration::Institution; > > use strict; > use warnings; >-use English; >-# use Exporter; > > sub new { > my ($class, $obj) = @_; >diff --git a/C4/SIP/Sip/Configuration/Service.pm b/C4/SIP/Sip/Configuration/Service.pm >index b5e37e8..34a02b1 100644 >--- a/C4/SIP/Sip/Configuration/Service.pm >+++ b/C4/SIP/Sip/Configuration/Service.pm >@@ -7,8 +7,6 @@ package Sip::Configuration::Service; > > use strict; > use warnings; >-use English; >-# use Exporter; > > sub new { > my ($class, $obj) = @_; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8433
:
10802
|
14242
| 14416