Bugzilla – Attachment 144161 Details for
Bug 24606
Allow storing item values as a template for creating new items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24606: (QA follow-up) Fix Template.t
Bug-24606-QA-follow-up-Fix-Templatet.patch (text/plain), 1.43 KB, created by
Marcel de Rooy
on 2022-11-22 15:50:50 UTC
(
hide
)
Description:
Bug 24606: (QA follow-up) Fix Template.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-11-22 15:50:50 UTC
Size:
1.43 KB
patch
obsolete
>From 12b646a38cb902e5e5d012ad35039e0eb50a64cb Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 22 Nov 2022 15:49:02 +0000 >Subject: [PATCH] Bug 24606: (QA follow-up) Fix Template.t >Content-Type: text/plain; charset=utf-8 > >The test cases here still assumed UTF-8 enocding in the middle >of the process. Can be much simpler. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Koha/Item/Template.t | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > >diff --git a/t/db_dependent/Koha/Item/Template.t b/t/db_dependent/Koha/Item/Template.t >index 6acb5c6ad0..8174c2dd44 100755 >--- a/t/db_dependent/Koha/Item/Template.t >+++ b/t/db_dependent/Koha/Item/Template.t >@@ -50,18 +50,8 @@ subtest 'Serializing and deserializing contents' => sub { > } > )->store(); > >- my $encoded_data; >- foreach my $key ( keys %{$data} ) { >- $encoded_data->{$key} = Encode::encode('UTF-8', $data->{$key}); >- } >- >- is( $template->contents, JSON->new->utf8->encode($data), 'Contents serialized correctly' ); >- >- is_deeply( >- $template->decoded_contents, >- $encoded_data, >- 'Contents deserialized and UTF-8 encoded correctly' >- ); >+ is( $template->contents, JSON->new->encode($data), 'Contents serialized correctly' ); >+ is_deeply( $template->decoded_contents, $data, 'Contents deserialized correctly' ); > > $schema->storage->txn_rollback; > }; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24606
:
141613
|
141614
|
141615
|
141616
|
141617
|
141717
|
141718
|
141719
|
141720
|
141721
|
141972
|
142003
|
142004
|
142005
|
142006
|
142007
|
142008
|
142833
|
142834
|
142835
|
142836
|
142837
|
142877
|
142878
|
142879
|
142880
|
142881
|
142882
|
142883
|
142884
|
142885
|
142886
|
142887
|
142888
|
143020
|
143569
|
143570
|
143571
|
143572
|
143573
|
143574
|
143575
|
143576
|
143577
|
143578
|
143579
|
143580
|
143581
|
143794
|
143795
|
143796
|
143989
|
143990
| 144161