Bugzilla – Attachment 144177 Details for
Bug 28235
Custom cover images are very large in staff search results and OPAC details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28235: Correct CSS governing max width of custom cover images
Bug-28235-Correct-CSS-governing-max-width-of-custo.patch (text/plain), 2.99 KB, created by
David Nind
on 2022-11-22 22:32:49 UTC
(
hide
)
Description:
Bug 28235: Correct CSS governing max width of custom cover images
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-11-22 22:32:49 UTC
Size:
2.99 KB
patch
obsolete
>From 8e7aedc2cb2c42b52197fa230a02c6252b34e5aa Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 18 Nov 2022 14:02:13 +0000 >Subject: [PATCH] Bug 28235: Correct CSS governing max width of custom cover > images > >Images shown in the OPAC and staff interface when the >OPACCustomCoverImages and CustomCoverImages preferences are enabled >should be getting a max-width set in the current CSS, but the order of >the declarations is preventing the correct specificity. > >This patch moves the CSS to the correct place in each file so that the >max-width is applied. > >To test, apply the patch and rebuild both the staff and OPAC CSS. If you >get an error during the build process you may need to run 'yarn >install.' > >- Go to Administration -> System preferences, and enable the > OPACCustomCoverImages and CustomCoverImages preferences. >- If you're testing with the default test database you can set the > CustomCoverImagesURL preference to > https://static.myacpl.org/public/covers/{normalized_isbn}.jpg >- Perform a catalog search in both OPAC and staff client limiting by > itemtype = 'Book'. >- The search results in both interface should show several covers > supplied from the external URL. >- In the staff client, these images should be limited to 140px wide even > if the source image is larger. >- In the OPAC, view the detail page for one of the results with cover > images. The image shown on the detail page should be constrained to > 140px wide even if the source image is larger. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../intranet-tmpl/prog/css/src/staff-global.scss | 12 ++++++------ > koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 12 ++++++------ > 2 files changed, 12 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 054b6bf3a8..27c7838657 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -2072,12 +2072,6 @@ li { > text-align: center; > } > >-.custom_cover_image { >- img { >- max-width: 140px; >- } >-} >- > #biblio-cover-slider { > border: 1px solid #bfd9b9; > border-radius: 3px; >@@ -2154,6 +2148,12 @@ td { > } > } > >+.custom_cover_image { >+ img { >+ max-width: 140px; >+ } >+} >+ > .cover-nav { > display: inline-block; > padding: 3px 4px; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >index 63434d3cbf..8af3afa2ed 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >@@ -713,12 +713,6 @@ th { > } > } > >-.custom_cover_image { >- img { >- max-width: 140px; >- } >-} >- > #biblio-cover-slider { > background-color: #FFF; > border: 1px solid #B9D8D9; >@@ -755,6 +749,12 @@ th { > } > } > >+.custom_cover_image { >+ img { >+ max-width: 140px; >+ } >+} >+ > .cover-nav { > display: inline-block; > padding: 3px 4px; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28235
:
142841
|
144072
|
144177
|
144419
|
144421