Attachment 144187 Details for Bug 32303 – Bug 32303: Remove DT pagination on system preference search result

[patch] Bug 32303: Remove DT pagination on system preference search result

Bug-32303-Remove-DT-pagination-on-system-preferenc.patch (text/plain), 2.24 KB, created by Jonathan Druart on 2022-11-23 08:06:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-11-23 08:06:19 UTC

Size: 2.24 KB

patch

obsolete

>From 0f0cc669d17a898a5762195beaae1970933c9578 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 22 Nov 2022 15:19:52 +0000
>Subject: [PATCH] Bug 32303: Remove DT pagination on system preference search
> result
>
>This patch updates the way we retrieve a DataTable's saved state during
>initialization. The change is to prevent cases where making a duplicate
>call to DataTables() initializes the table again.
>
>To recreate the bug, search system preferences for the term "last."
>Scroll down to the "OPAC preferences" section and observe that there are
>two filter forms displayed above it.
>
>Apply the patch and perform the same search again. The extra forms
>should be gone.
>
>Confirm that DataTables behavior is still the same:
>
> - Test pages which use the "saveState" option in DataTables.
>   - Type text in the table's search field
>   - Reload the page. The search field should still have the string you
>     entered, and the "Clear filter" button should be active.
>     - Administration -> Libraries
>     - Acquisitions -> Vendor -> Receive shipments -> Receive orders
>     - Circulation -> Overdues
>
> - Test pages which don't use the "saveState" option, e.g. the checkout
>   screen, patron search results, list of saved reports, etc. The
>   behavior of the search form and table operations in general should be
>   unchanged.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/js/datatables.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>index 94a532b19e7..0fbb9b625cb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>@@ -53,7 +53,7 @@ var dataTablesDefaults = {
>     "fixedHeader": true,
>     initComplete: function( settings) {
>         var tableId = settings.nTable.id
>-        var state =  $("#" + tableId ).DataTable().state();
>+        var state =  settings.oLoadedState;
>         state && toggledClearFilter(state.search.search, tableId);
>         // When the DataTables search function is triggered,
>         // enable or disable the "Clear filter" button based on
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 32303: 144159 | 144178 | 144187