Attachment 144196 Details for Bug 31381 – Bug 31381: Handle null attributes in list

[patch] Bug 31381: Handle null attributes in list

Bug-31381-Handle-null-attributes-in-list.patch (text/plain), 1.38 KB, created by Nick Clemens (kidclamp) on 2022-11-23 10:56:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-11-23 10:56:41 UTC

Size: 1.38 KB

patch

obsolete

>From 91057c95a34e6dd76f20750fd423f43d2a169a4d Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 22 Nov 2022 19:21:22 +0000
>Subject: [PATCH] Bug 31381: Handle null attributes in list
>
>This patch allows null values to be returned in patron attributes
>to prevent a crash when searching patrons
>
>To test:
>1 - Add a NULL attribute to a borrower, in sample data, Edna Acosta
>    sudo koha-mysql kohadev
>    INSERT INTO borrower_attributes (borrowernumber,code,attribute) VALUES (5,'SHOW_BCODE',NULL);
>2 - Browse to 'Home->Patrons'
>    http://localhost:8081/cgi-bin/koha/members/members-home.pl
>3 - Click 'Browse by last name: A'
>4 - Datatables error:
>    Expected string - got null
>5 - Apply patch
>6 - Restart all
>7 - Browse by last name: A
>8 - Success!
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> api/v1/swagger/definitions/patron_extended_attribute.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/api/v1/swagger/definitions/patron_extended_attribute.yaml b/api/v1/swagger/definitions/patron_extended_attribute.yaml
>index 84343d258b..4bfd8567e9 100644
>--- a/api/v1/swagger/definitions/patron_extended_attribute.yaml
>+++ b/api/v1/swagger/definitions/patron_extended_attribute.yaml
>@@ -11,6 +11,7 @@ properties:
>     description: Extended attribute value
>     type:
>       - string
>+      - "null"
> additionalProperties: false
> required:
>   - type
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31381: 144173 | 144188 | 144196 | 144197 | 144351 | 144352